Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer versions of OpenCV built from source #35

Open
psyhtest opened this issue Apr 9, 2020 · 1 comment
Open

Support newer versions of OpenCV built from source #35

psyhtest opened this issue Apr 9, 2020 · 1 comment

Comments

@psyhtest
Copy link
Contributor

psyhtest commented Apr 9, 2020

The versions of OpenCV we currently support are quite old:

$ ck search package --tags=lib,opencv,channel-stable
ck-math:package:lib-opencv-3.4.5
ck-math:package:lib-opencv-3.3.0
ck-math:package:lib-opencv-2.4.13.2
ck-math:package:lib-opencv-3.4.3
ck-math:package:lib-opencv-3.2.0

The latest releases are 3.4.10 and 4.3.0. (Intel used 4.1.2 in the MLPerf Inference v0.5 submission.)

Adding support for 3.4.10 should be quite easy:

  1. Test you can build OpenCV 3.4.3 on your system:
$ ck install package --tags=lib,opencv,v3.4.3
  1. Fork repo:ck-math to your GitHub account e.g. i_want_to_help.

  2. Switch your local repo:ck-math to your new remote fork and create a branch there: e.g.

$ cd `ck find repo:ck-math`
$ git remote set-url origin [email protected]:i_want_to_help/ck-math
$ git checkout -b opencv-3.4.10
  1. Create a copy of the OpenCV 3.4.3 package:
$ ck cp ck-math:package:lib-opencv-3.4.3 ck-math:package:lib-opencv-3.4.10
  1. Modify the copy to replace "3.4.3" with "3.4.10" everywhere in meta.json.

  2. Test you can build the new package:

$ ck install package --tags=lib,opencv,v3.4.10
  1. Commit the change and push your branch to your remote.

  2. Issue a Pull Request from your remote to https://github.com/ctuning/ck-math.

  3. Repeat on another system (Windows, MacOS?)

  4. Try the same with the latest OpenCV 4.x version.

@psyhtest
Copy link
Contributor Author

A much better approach to copying would be to create a new ck-math:package:lib-opencv with variations for different versions and options. For example:

@psyhtest psyhtest transferred this issue from ctuning/ck-openvino Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant