Skip to content

Commit eb60f1b

Browse files
committed
parser-common: rename LangDetector -> ImpliedAttrDigger
... so that its purpose can be extended to cover other attributes No changes in behavior intended by this commit.
1 parent 3daaaa3 commit eb60f1b

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

src/csparser.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ struct CovParser::Private {
424424
EToken code;
425425
KeyEventDigger keDigger;
426426
AnnotHandler annotHdl;
427-
LangDetector langDetector;
427+
ImpliedAttrDigger digger;
428428

429429
Private(InStream &input_):
430430
lexer(input_.str()),
@@ -611,7 +611,7 @@ bool CovParser::Private::parseNext(Defect *def)
611611

612612
this->keDigger.initVerbosity(def);
613613
this->annotHdl.handleDef(def);
614-
this->langDetector.inferLangFromChecker(def);
614+
this->digger.inferLangFromChecker(def);
615615

616616
// all OK
617617
return true;

src/gcc-parser.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ bool BasicGccParser::hasError() const
561561
using namespace GccParserImpl;
562562

563563
struct GccPostProcessor::Private {
564-
const LangDetector langDetector;
564+
const ImpliedAttrDigger digger;
565565

566566
void transGccAnal(Defect *pDef) const;
567567
void polishGccAnal(Defect *pDef) const;
@@ -678,7 +678,7 @@ void GccPostProcessor::apply(Defect *pDef) const
678678
d->polishGccAnal(pDef);
679679
d->polishClangAnal(pDef);
680680

681-
d->langDetector.inferLangFromChecker(pDef);
681+
d->digger.inferLangFromChecker(pDef);
682682
}
683683

684684
struct GccParser::Private {

src/parser-common.cc

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ int parse_int(const std::string &str, const int fallback)
3131
}
3232
}
3333

34-
struct LangDetector::Private {
34+
struct ImpliedAttrDigger::Private {
3535
typedef std::map<std::string, std::string> TMap;
3636
TMap langByChecker;
3737
};
3838

39-
LangDetector::LangDetector():
39+
ImpliedAttrDigger::ImpliedAttrDigger():
4040
d(new Private)
4141
{
4242
d->langByChecker["CLANG_WARNING"] = "c/c++";
@@ -48,12 +48,14 @@ LangDetector::LangDetector():
4848
d->langByChecker["SMATCH_WARNING"] = "c/c++";
4949
}
5050

51-
LangDetector::~LangDetector()
51+
ImpliedAttrDigger::~ImpliedAttrDigger()
5252
{
5353
delete d;
5454
}
5555

56-
void LangDetector::inferLangFromChecker(Defect *pDef, const bool onlyIfMissing)
56+
void ImpliedAttrDigger::inferLangFromChecker(
57+
Defect *pDef,
58+
const bool onlyIfMissing)
5759
const
5860
{
5961
if (onlyIfMissing && !pDef->language.empty())

src/parser-common.hh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@
3535

3636
int parse_int(const std::string &, int fallback = 0);
3737

38-
class LangDetector {
38+
class ImpliedAttrDigger {
3939
public:
40-
LangDetector();
41-
~LangDetector();
40+
ImpliedAttrDigger();
41+
~ImpliedAttrDigger();
4242

4343
void inferLangFromChecker(Defect *, bool onlyIfMissing = true) const;
4444

0 commit comments

Comments
 (0)