Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ 17 needed with torch 2.1 #80

Closed
yuekaizhang opened this issue Nov 3, 2023 · 5 comments
Closed

C++ 17 needed with torch 2.1 #80

yuekaizhang opened this issue Nov 3, 2023 · 5 comments

Comments

@yuekaizhang
Copy link

Seems that Pytorch 2.1 (current default version) compiled with C++ 17. So, https://github.com/csukuangfj/kaldifeat/blob/master/CMakeLists.txt#L35 this line may need to change to 17, otherwise, we can't install it from source.

Error: C++17 or later compatible compiler is required

@csukuangfj
Copy link
Owner

Please see #81

@yuekaizhang
Copy link
Author

Thanks, but how do you fix it in 20 mins :D

@csukuangfj
Copy link
Owner

Thanks, but how do you fix it in 20 mins :D

It has been fixed last week.

You can find pre-build wheels for torch 2.1 at
https://csukuangfj.github.io/kaldifeat/cuda.html

@pzelasko
Copy link

It seems to still pop up, I'm adding python 3.12 and updating torch versions in Lhotse CI, unfortunately some configurations can't build, e.g.: https://github.com/lhotse-speech/lhotse/actions/runs/7888121954/job/21524871882?pr=1288

@csukuangfj
Copy link
Owner

It seems to still pop up, I'm adding python 3.12 and updating torch versions in Lhotse CI, unfortunately some configurations can't build, e.g.: https://github.com/lhotse-speech/lhotse/actions/runs/7888121954/job/21524871882?pr=1288

please use https://csukuangfj.github.io/kaldifeat/installation/from_wheels.html to install kaldifeat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants