Skip to content

Commit d64c4ae

Browse files
authoredNov 30, 2024
Merge pull request DaleStudy#621 from HC-kang/main
Chore: integration workflow์— ๋‹ต์•ˆ ํŒŒ์ผ ๋ช…์„ "GitHub๊ณ„์ •๋ช…".ext ํ˜•ํƒœ๋กœ ๊ฐ•์ œํ•˜๋Š” step ์ถ”๊ฐ€
2 parents 57cb89c + adb1dc8 commit d64c4ae

File tree

1 file changed

+71
-27
lines changed

1 file changed

+71
-27
lines changed
 

โ€Ž.github/workflows/integration.yaml

+71-27
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,30 @@ jobs:
1111
with:
1212
fetch-depth: 0
1313

14-
- name: Check for 1. missing end line breaks and 2. control characters in filenames
14+
# PR ๋ผ๋ฒจ ํ™•์ธ
15+
- name: Get PR labels
16+
id: pr-labels
17+
run: |
18+
pr_number="${{ github.event.pull_request.number }}"
19+
labels_json=$(gh pr view $pr_number --json labels -q '.labels[].name')
20+
if [ -n "$labels_json" ]; then
21+
echo "has_maintenance=$(echo $labels_json | grep -q 'maintenance' && echo 'true' || echo 'false')" >> $GITHUB_OUTPUT
22+
else
23+
echo "has_maintenance=false" >> $GITHUB_OUTPUT
24+
fi
25+
env:
26+
GH_TOKEN: ${{ github.token }}
27+
28+
# ์ค„๋ฐ”๊ฟˆ ์ฒดํฌ
29+
- name: Check for missing end line breaks
1530
run: |
1631
# ๋”ฐ์˜ดํ‘œ๋ฅผ ์ œ๊ฑฐํ•˜๊ณ  ํŒŒ์ผ ๋ชฉ๋ก ๊ฐ€์ ธ์˜ค๊ธฐ
1732
files=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | tr -d '"')
33+
success=true
34+
1835
echo "๋ณ€๊ฒฝ๋œ ํŒŒ์ผ ๋ชฉ๋ก:"
1936
echo "$files"
20-
21-
success=true
2237
23-
# ์ค„๋ฐ”๊ฟˆ ์ฒดํฌ
2438
echo "## ์ค„๋ฐ”๊ฟˆ ๋ˆ„๋ฝ ํŒŒ์ผ" >> $GITHUB_STEP_SUMMARY
2539
for file in $files; do
2640
if [ -s "$file" ] && [ "$(tail -c 1 $file | wc -l)" -eq 0 ]; then
@@ -30,40 +44,70 @@ jobs:
3044
fi
3145
done
3246
33-
# ์ œ์–ด๋ฌธ์ž ์ฒดํฌ
34-
echo -e "\n## ์ œ์–ด๋ฌธ์ž๊ฐ€ ํฌํ•จ๋œ ํŒŒ์ผ๋ช…" >> $GITHUB_STEP_SUMMARY
47+
if [ "$success" = false ]; then
48+
echo -e "\n:warning: ํŒŒ์ผ ๋์˜ ๋ˆ„๋ฝ๋œ ์ค„๋ฐ”๊ฟˆ์„ ์ถ”๊ฐ€ํ•ด ์ฃผ์„ธ์š”." >> $GITHUB_STEP_SUMMARY
49+
exit 1
50+
fi
51+
52+
# ์ œ์–ด๋ฌธ์ž ์ฒดํฌ
53+
- name: Check for control characters in filenames
54+
run: |
55+
files=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | tr -d '"')
56+
success=true
57+
58+
echo "## ์ œ์–ด๋ฌธ์ž๊ฐ€ ํฌํ•จ๋œ ํŒŒ์ผ๋ช…" >> $GITHUB_STEP_SUMMARY
3559
for file in $files; do
3660
# basename์œผ๋กœ ํŒŒ์ผ๋ช…๋งŒ ์ถ”์ถœํ•˜๊ณ  ๋”ฐ์˜ดํ‘œ ์ œ๊ฑฐ
3761
filename=$(basename "$file" | tr -d '"')
38-
62+
3963
# ๋ฐฑ์Šฌ๋ž˜์‹œ๋กœ ์‹œ์ž‘ํ•˜๋Š” ์ œ์–ด๋ฌธ์ž๋“ค ์ฒดํฌ (\b, \n, \r, \t ๋“ฑ)
40-
if printf '%q' "$filename" | grep -q '\\[bnrtfv]'; then
41-
echo "- $file (์ œ์–ด๋ฌธ์ž ํฌํ•จ)" >> $GITHUB_STEP_SUMMARY
42-
success=false
43-
fi
44-
45-
# ์ผ๋ฐ˜์ ์ธ ์ œ์–ด๋ฌธ์ž๋“ค ์ฒดํฌ (0x00-0x1F, 0x7F)
46-
if echo -n "$filename" | LC_ALL=C grep -q '[[:cntrl:]]'; then
47-
echo "- $file (์ œ์–ด๋ฌธ์ž ํฌํ•จ)" >> $GITHUB_STEP_SUMMARY
48-
success=false
49-
fi
64+
if printf '%q' "$filename" | grep -q '\\[bnrtfv]' || \
65+
66+
# ์ผ๋ฐ˜์ ์ธ ์ œ์–ด๋ฌธ์ž๋“ค ์ฒดํฌ (0x00-0x1F, 0x7F)
67+
echo -n "$filename" | LC_ALL=C grep -q '[[:cntrl:]]' || \
5068
51-
# ํŠน์ˆ˜ ์ œ์–ด๋ฌธ์ž๋“ค ์ฒดํฌ
52-
if echo -n "$filename" | grep -q $'[\x00-\x1F\x7F]'; then
69+
# ํŠน์ˆ˜ ์ œ์–ด๋ฌธ์ž๋“ค ์ฒดํฌ
70+
echo -n "$filename" | grep -q $'[\x00-\x1F\x7F]' || \
71+
72+
# ์ด์Šค์ผ€์ดํ”„ ์‹œํ€€์Šค ์ฒดํฌ
73+
[[ "$filename" =~ (\\[0-7]{1,3}|\\x[0-9a-fA-F]{1,2}) ]]; then
5374
echo "- $file (์ œ์–ด๋ฌธ์ž ํฌํ•จ)" >> $GITHUB_STEP_SUMMARY
5475
success=false
5576
fi
56-
57-
# ์ด์Šค์ผ€์ดํ”„ ์‹œํ€€์Šค ์ฒดํฌ
58-
if [[ "$filename" =~ (\\[0-7]{1,3}|\\x[0-9a-fA-F]{1,2}) ]]; then
59-
echo "- $file (์ œ์–ด๋ฌธ์ž ํฌํ•จ)" >> $GITHUB_STEP_SUMMARY
60-
success=false
77+
done
78+
79+
if [ "$success" = false ]; then
80+
echo -e "\n:warning: ํŒŒ์ผ๋ช…์—์„œ ์ œ์–ด๋ฌธ์ž๋ฅผ ์ œ๊ฑฐํ•ด ์ฃผ์„ธ์š”." >> $GITHUB_STEP_SUMMARY
81+
exit 1
82+
fi
83+
84+
# ํŒŒ์ผ๋ช… ๊ทœ์น™ ์ฒดํฌ - maintenance ๋ผ๋ฒจ์ด ์—†๋Š” ๊ฒฝ์šฐ์—๋งŒ ์‹คํ–‰
85+
- name: Check filename rules
86+
if: ${{ steps.pr-labels.outputs.has_maintenance != 'true' }}
87+
run: |
88+
files=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | tr -d '"')
89+
pr_author="${{ github.event.pull_request.user.login }}"
90+
success=true
91+
92+
echo "## ํŒŒ์ผ๋ช… ๊ทœ์น™ ์œ„๋ฐ˜" >> $GITHUB_STEP_SUMMARY
93+
for file in $files; do
94+
if [ -f "$file" ]; then
95+
96+
# ํŒŒ์ผ๋ช…๋งŒ ์ถ”์ถœ (๊ฒฝ๋กœ ์ œ์™ธ)
97+
filename=$(basename "$file")
98+
99+
# ํŒŒ์ผ๋ช…์ด GitHub๊ณ„์ •๋ช…์ธ์ง€ ํ™•์ธ
100+
shopt -s nocasematch
101+
if [[ ! "$filename" = "$pr_author"* ]]; then
102+
echo "- $file" >> $GITHUB_STEP_SUMMARY
103+
success=false
104+
fi
61105
fi
62106
done
63107
64108
if [ "$success" = false ]; then
65-
echo -e "\n:warning: ์œ„ ๋ฌธ์ œ๋“ค์„ ํ•ด๊ฒฐํ•ด ์ฃผ์„ธ์š”:" >> $GITHUB_STEP_SUMMARY
66-
echo "1. ํŒŒ์ผ ๋์˜ ๋ˆ„๋ฝ๋œ ์ค„๋ฐ”๊ฟˆ์„ ์ถ”๊ฐ€ํ•ด ์ฃผ์„ธ์š”." >> $GITHUB_STEP_SUMMARY
67-
echo "2. ํŒŒ์ผ๋ช…์—์„œ ์ œ์–ด๋ฌธ์ž๋ฅผ ์ œ๊ฑฐํ•ด ์ฃผ์„ธ์š”." >> $GITHUB_STEP_SUMMARY
109+
echo -e "\n:warning: ํŒŒ์ผ๋ช…์€ ๋ฐ˜๋“œ์‹œ 'GitHub๊ณ„์ •๋ช…' ๋˜๋Š” 'GitHub๊ณ„์ •๋ช…-xxx' ํ˜•์‹์œผ๋กœ ํ•ด์ฃผ์…”์•ผ ํ•ฉ๋‹ˆ๋‹ค. (์˜ˆ: ${pr_author}.ts, ${pr_author}-1.ts, ${pr_author}-2.ts)" >> $GITHUB_STEP_SUMMARY
68110
exit 1
69111
fi
112+
env:
113+
GH_TOKEN: ${{ github.token }}

0 commit comments

Comments
 (0)