remove unneeded constructors

cslab · Jul 11, 2024 · 88b430b · 88b430b
1 parent 8e528dd
commit 88b430b
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 22 deletions.
diff --git a/csfunctions/events/document_release.py b/csfunctions/events/document_release.py
@@ -9,17 +9,11 @@
 
 
 class DocumentReleaseData(BaseModel):
-    def __init__(self, documents: list[Document], parts: list[Part], dialog_data: dict, **kwargs):
-        super().__init__(documents=documents, parts=parts, dialog_data=dialog_data, **kwargs)
-
     documents: list[Document] = Field(..., description="List of documents that were released.")
     parts: list[Part] = Field(..., description="List of parts that belong to the released documents")
     dialog_data: DocumentReleaseDialogData
 
 
 class DocumentReleaseEvent(BaseEvent):
-    def __init__(self, event_id: str, data: DocumentReleaseData, **_):
-        super().__init__(name=EventNames.DOCUMENT_RELEASE, event_id=event_id, data=data)
-
-    name: Literal[EventNames.DOCUMENT_RELEASE]
+    name: Literal[EventNames.DOCUMENT_RELEASE] = EventNames.DOCUMENT_RELEASE
     data: DocumentReleaseData
diff --git a/csfunctions/events/engineering_change_release.py b/csfunctions/events/engineering_change_release.py
@@ -16,8 +16,5 @@ class EngineeringChangeReleaseData(BaseModel):
 
 
 class EngineeringChangeRelease(BaseEvent):
-    def __init__(self, event_id: str, data: EngineeringChangeReleaseData, **_):
-        super().__init__(name=EventNames.ENGINEERING_CHANGE_RELEASE, event_id=event_id, data=data)
-
-    name: Literal[EventNames.ENGINEERING_CHANGE_RELEASE]
+    name: Literal[EventNames.ENGINEERING_CHANGE_RELEASE] = EventNames.ENGINEERING_CHANGE_RELEASE
     data: EngineeringChangeReleaseData
diff --git a/csfunctions/events/part_release.py b/csfunctions/events/part_release.py
@@ -9,17 +9,11 @@
 
 
 class PartReleaseData(BaseModel):
-    def __init__(self, parts: list[Part], dialog_data: dict, **kwargs):
-        super().__init__(parts=parts, dialog_data=dialog_data, **kwargs)
-
     parts: list[Part] = Field(..., description="List if parts that were released.")
     documents: list[Document] = Field(..., description="List if documents that are referenced by the released part.")
     dialog_data: PartReleaseDialogData
 
 
 class PartReleaseEvent(BaseEvent):
-    def __init__(self, event_id: str, data: PartReleaseData, **_):
-        super().__init__(name=EventNames.PART_RELEASE, event_id=event_id, data=data)
-
-    name: Literal[EventNames.PART_RELEASE]
+    name: Literal[EventNames.PART_RELEASE] = EventNames.PART_RELEASE
     data: PartReleaseData
diff --git a/json_schemas/request.json b/json_schemas/request.json
@@ -862,6 +862,7 @@
       "properties": {
         "name": {
           "const": "document_release",
+          "default": "document_release",
           "enum": [
             "document_release"
           ],
@@ -878,7 +879,6 @@
         }
       },
       "required": [
-        "name",
         "event_id",
         "data"
       ],
@@ -1256,6 +1256,7 @@
       "properties": {
         "name": {
           "const": "engineering_change_release",
+          "default": "engineering_change_release",
           "enum": [
             "engineering_change_release"
           ],
@@ -1272,7 +1273,6 @@
         }
       },
       "required": [
-        "name",
         "event_id",
         "data"
       ],
@@ -2587,6 +2587,7 @@
       "properties": {
         "name": {
           "const": "part_release",
+          "default": "part_release",
           "enum": [
             "part_release"
           ],
@@ -2603,7 +2604,6 @@
         }
       },
       "required": [
-        "name",
         "event_id",
         "data"
       ],

diff --git a/tests/events/test_ec_release.py b/tests/events/test_ec_release.py
@@ -18,7 +18,7 @@ def test_link_objects(self):
         data = EngineeringChangeReleaseData(
             documents=[document], parts=[part], engineering_changes=[engineering_change]
         )
-        event = EngineeringChangeRelease("123", data)
+        event = EngineeringChangeRelease(event_id="123", data=data)
         request.event = event
 
         # objects are not linked yet