Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIDL reminders in generated files? #68

Closed
teuben opened this issue Jun 29, 2020 · 3 comments
Closed

SIDL reminders in generated files? #68

teuben opened this issue Jun 29, 2020 · 3 comments
Labels
documentation

Comments

@teuben
Copy link

teuben commented Jun 29, 2020

If certain files (e.g. bmi-c/bmi.h) are generated via the bmi.sidl and some procedure, this fact should be a comment in those files, as to yet again remind authors of the proper workflow.

openjournals/joss-reviews#2317
@mdpiper
Copy link
Member

mdpiper commented Jul 6, 2020 •
edited
Loading

@teuben On a slightly tangential point, the language spec files (like bmi-c/bmi.h) are created manually. However, it would be a really good idea to generate them programmatically. @mcflugen and I are scoping out the work for this now.

This was referenced Jul 9, 2020
Merged
Merged
Merged
Merged
Closed
@teuben
Copy link
Author

teuben commented Jul 14, 2020

given #71 this can be closed I guess.

@mdpiper
Copy link
Member

mdpiper commented Jul 14, 2020

Thanks, @teuben!

@mdpiper mdpiper closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teuben @mdpiper