Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release example bmi on PyPI #39

Open
BSchilperoort opened this issue Dec 11, 2024 · 5 comments
Open

Release example bmi on PyPI #39

BSchilperoort opened this issue Dec 11, 2024 · 5 comments

Comments

@BSchilperoort
Copy link

BSchilperoort commented Dec 11, 2024

If this example implementation is available on PyPI it can more easily be used in, for example;

  1. tests in other packages that build upon BMI*
  2. JupyterLite notebooks (see Provide Python wheels bmi-python#60: don't forget to publish wheels too).

*in grpc4bmi we need an extra requirements file because this gh repo cannot be refered to in the pyproject.toml file.

@mdpiper
Copy link
Member

mdpiper commented Dec 17, 2024

I've been thinking about this over the years. I hesitated because I felt it wasn't appropriate to package an example (instead of a library) for distribution. These use cases might be enough to change my mind. What do you think, @mcflugen?

We could also consider packaging the C, C++, Fortran, and Python examples on conda-forge.

@mcflugen
Copy link
Member

mcflugen commented Dec 17, 2024

Sounds like a good idea to me.

Maybe we could even include the C, and C++ (and, possibly, fortran) examples in the distribution on PyPI.

@BSchilperoort
Copy link
Author

Maybe we could even include the C, and C++ (and, possibly, fortran) examples in the distribution on PyPI.

The downside of that would be that you need to compile that per platform & per architecture. Just publishing the Python example case is a lot simpler (and will work everywhere).

@mcflugen
Copy link
Member

The downside of that would be that you need to compile that per platform & per architecture

For sure. We do that with some other projects and it is a bit of a pain, but not too bad. I'm not sure if it would be worth it in this case, though.

@mdpiper
Copy link
Member

mdpiper commented Dec 19, 2024

We'd build conda packages for all the language examples + a PyPI package for the Python example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants