Skip to content

Commit 408b49f

Browse files
authored
Breaking changes in android V3 (#7)
* update example to use 2.0.0 version * added android configs * v2.0.0-rc-1.0 * android configs * update example
1 parent ef85643 commit 408b49f

File tree

7 files changed

+32
-6
lines changed

7 files changed

+32
-6
lines changed

android/src/main/java/com/csath/RNConfigReaderModule.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@
1515
public class RNConfigReaderModule extends ReactContextBaseJavaModule {
1616

1717
private final ReactApplicationContext reactContext;
18+
private final Class buildConfigClass;
1819

19-
public RNConfigReaderModule(ReactApplicationContext reactContext) {
20+
public RNConfigReaderModule(ReactApplicationContext reactContext, Class buildConfigClass) {
2021
super(reactContext);
2122
this.reactContext = reactContext;
23+
this.buildConfigClass = buildConfigClass;
2224
}
2325

2426
@Override
@@ -29,7 +31,7 @@ public String getName() {
2931
@Override
3032
public Map<String, Object> getConstants() {
3133
final Map<String, Object> constants = new HashMap<>();
32-
Field[] fields = BuildConfig.class.getDeclaredFields();
34+
Field[] fields = this.buildConfigClass.getDeclaredFields();
3335
for (Field f : fields) {
3436
if (Modifier.isStatic(f.getModifiers())) {
3537
Object value = null;

android/src/main/java/com/csath/RNConfigReaderPackage.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,14 @@
1212
import com.facebook.react.bridge.JavaScriptModule;
1313

1414
public class RNConfigReaderPackage implements ReactPackage {
15+
private final Class buildConfigclass;
16+
17+
public RNConfigReaderPackage(Class buildConfigclass) {
18+
this.buildConfigclass = buildConfigclass;
19+
}
1520
@Override
1621
public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
17-
return Arrays.<NativeModule>asList(new RNConfigReaderModule(reactContext));
22+
return Arrays.<NativeModule>asList(new RNConfigReaderModule(reactContext, this.buildConfigclass));
1823
}
1924

2025
// Deprecated from RN 0.47

example/android/.project

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<projectDescription>
3+
<name>android</name>
4+
<comment>Project android created by Buildship.</comment>
5+
<projects>
6+
</projects>
7+
<buildSpec>
8+
<buildCommand>
9+
<name>org.eclipse.buildship.core.gradleprojectbuilder</name>
10+
<arguments>
11+
</arguments>
12+
</buildCommand>
13+
</buildSpec>
14+
<natures>
15+
<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
16+
</natures>
17+
</projectDescription>
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
connection.project.dir=
2+
eclipse.preferences.version=1

example/android/app/src/main/java/com/testconfig/MainApplication.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public boolean getUseDeveloperSupport() {
2424
protected List<ReactPackage> getPackages() {
2525
return Arrays.<ReactPackage>asList(
2626
new MainReactPackage(),
27-
new RNConfigReaderPackage()
27+
new RNConfigReaderPackage(BuildConfig.class)
2828
);
2929
}
3030

example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"dependencies": {
1010
"react": "16.8.3",
1111
"react-native": "0.59.3",
12-
"react-native-config-reader": "^2.0.0"
12+
"react-native-config-reader": "^3.0.0"
1313
},
1414
"devDependencies": {
1515
"@babel/core": "^7.4.3",

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-config-reader",
3-
"version": "2.0.0",
3+
"version": "2.0.0-rc-1.0",
44
"description": "Simply access android build configs and ios info.plist values in JS",
55
"main": "index.js",
66
"scripts": {

0 commit comments

Comments
 (0)