Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speller check incorrect #160

Open
OtherBlue opened this issue Jan 6, 2023 · 0 comments
Open

Speller check incorrect #160

OtherBlue opened this issue Jan 6, 2023 · 0 comments
Labels
CS50x CS50x

Comments

@OtherBlue
Copy link

OtherBlue commented Jan 6, 2023

I started cs50x in 2021, and the speller check50 gave me all green smiles despite the fact that (as I have just discovered after comparing it with speller50 before resubmission) the results are extremely far apart in correctness.
comparing it with speller50 in lalaland.txt, the correct answer showed 955, while my old solution registered 10887, despite that, the latest check50 still registers the answer as correct.

I believe I have located the mistake in my old code to be in the load function, specifically on the line table[h]->next = NULL; which was removing a lot of words from the loaded dictionary

I don't know exactly which parts of my dictionary.c are used for check50, and it seems said mistake only passed through because of the djb2 hash function used in that submission, as changing said function (since the newer version no longer allows you to use an existing hash function) and I am unsure if the check would pass with other hash functions, but I think it might be good to look into it

@rongxin-liu rongxin-liu added the CS50x CS50x label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CS50x CS50x
Projects
None yet
Development

No branches or pull requests

2 participants