Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM: creating an invite token should return 201 #4838

Open
butonic opened this issue Sep 5, 2024 · 1 comment
Open

OCM: creating an invite token should return 201 #4838

butonic opened this issue Sep 5, 2024 · 1 comment

Comments

@butonic
Copy link
Contributor

butonic commented Sep 5, 2024

we seem to use the wrong response code when creating an ocm invite token. I wanted to change it, but the tests say we should return a 200 Status code:

• [FAILED] [8.186 seconds]
ocm invitation workflow clients use the http endpoints exposed by sciencemesh generate the token from http apis [It] succeeds
/drone/src/tests/integration/grpc/ocm_invitation_test.go:519

  [FAILED] Expected
      <int>: 201
  to equal
      <int>: 200
  In [It] at: /drone/src/tests/integration/grpc/ocm_invitation_test.go:525 @ 09/05/24 09:17:45.026
------------------------------

While I strongly disagree. I'll revert that change and rerun the CI of #4836. For now.

@glpatcern
Copy link
Member

Going through issues, I see this one - and I agree with your disagreement @butonic :) This being off OCM, I think you can change the behavior and the test right away, and I should do the same on Reva master.

By the way, I'll see you next Wednesday, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants