Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-Candidate]: pre-commit does not work as documented #2549

Open
olexiyb opened this issue Sep 6, 2024 · 3 comments
Open

[Bug-Candidate]: pre-commit does not work as documented #2549

olexiyb opened this issue Sep 6, 2024 · 3 comments
Labels
bug-candidate Bugs reports that are not yet confirmed

Comments

@olexiyb
Copy link

olexiyb commented Sep 6, 2024

Describe the issue:

I have added in my .pre-commit-config.yaml

   - repo: https://github.com/crytic/slither
      rev: 0.10.4
      hooks:
        - id: slither

And I get

pre-commit/repoc36zuhi6/.pre-commit-hooks.yaml is not a file

For some reason tag version is missing .pre-commit-hooks.yaml file

Code example to reproduce the issue:

NA

Version:

0.10.4

Relevant log output:

No response

@olexiyb olexiyb added the bug-candidate Bugs reports that are not yet confirmed label Sep 6, 2024
@elopez
Copy link
Member

elopez commented Sep 6, 2024

Hi! #2521 was only merged very recently, so it's not yet available on any release. I'm guessing you could use rev: master in the meantime, but I'll defer to @dbast who added the feature 😄

@dbast
Copy link
Contributor

dbast commented Sep 6, 2024

yep. there was no release after the PR merge yet... till then the hook can be used via e.g.

- repo: https://github.com/crytic/slither
  # latest commit sha1 on master ... using just "master" as rev breaks hook caching
  rev: 16fd330723aca93dc3342dee77340e4b344dc732
  hooks:
    - id: slither

works here https://github.com/dbast/sol-press/blob/main/.pre-commit-config.yaml#L24

@olexiyb
Copy link
Author

olexiyb commented Sep 14, 2024

This is not a way how pre-commit should be used, as pre-commit autoupdate won't work
Anyway hopefully pre-commit config will be tagged in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-candidate Bugs reports that are not yet confirmed
Projects
None yet
Development

No branches or pull requests

3 participants