Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support icons next to items of the tray icon's popup menu #20

Open
sschuberth opened this issue Jun 16, 2023 · 6 comments
Open

Support icons next to items of the tray icon's popup menu #20

sschuberth opened this issue Jun 16, 2023 · 6 comments

Comments

@sschuberth
Copy link

It would be nice if the popup menu for the tray icon would support icons in front of its entries. Then indicators like "* " currently could be replaced with a nice "unlocked" icon.

@sschuberth
Copy link
Author

Hmm, looks like (some of) the code still uses AWT instead of Swing (or even JavaFX), which probably makes adding support for icons in menu item hard. So maybe an implementation based on a library like https://github.com/dorkbox/SystemTray would be feasible?

@purejava
Copy link
Contributor

We are already working on a change that uses native libs on Linux to show the tray icon:
cryptomator/integrations-linux#22
cryptomator/cryptomator#2885

The tray icon changes in case one of the vaults is unlocked and shows an unlocked lock symbol together with the Cryptomator icon then.

@sschuberth
Copy link
Author

sschuberth commented Jun 16, 2023

The tray icon changes in case one of the vaults is unlocked and shows an unlocked lock symbol together with the Cryptomator icon then.

Sounds nice, but what I was referring to is to show icons next to the items of the popup menu the tray menu opens, like next to "Green Mail" as shown here. Will that also be supported?

@infeo
Copy link
Member

infeo commented Jun 16, 2023

Not within the linked PRs. We would nee to extend/refactor the tray menu api to also support traymenu items containig different things than strings.

@sschuberth sschuberth changed the title Support icons for tray menu items Support icons next to items of the tray icon's popup menu Jun 16, 2023
@purejava
Copy link
Contributor

Sounds nice, but what I was referring to is to show icons next to the items of the popup menu the tray menu opens, like next to "Green Mail" as shown here. Will that also be supported?

SystemTray uses some hack to show the icons.

I'd definitely prefer a clean approach:

If you want to display an icon in a menu item, you should use GtkMenuItem and pack a GtkBox with a GtkImage and a GtkLabel instead.

@sschuberth
Copy link
Author

I'd definitely prefer a clean approach:

Me too, thanks for taking a look. As I'm curious about what the SystemTray folks (who seem to have a lot of expertise in this area) have to say, I've asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants