Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wait) GCC 9系のmemcmp問題 #163

Open
k-matsuzawa opened this issue Oct 1, 2020 · 4 comments
Open

(wait) GCC 9系のmemcmp問題 #163

k-matsuzawa opened this issue Oct 1, 2020 · 4 comments
Assignees
Labels
bug Something isn't working Epic epic story item

Comments

@k-matsuzawa
Copy link
Collaborator

Overview

  • bitcoin coreの、issue 20005 参照
    • 対策方針については上記待ち。
      • stlへの影響もありそうなため、CFD単体で有効な手段を取るよりも同じ対応としたい。

Completion condition

  • 該当する機能について修正できること。
@k-matsuzawa k-matsuzawa added the bug Something isn't working label Oct 1, 2020
@k-matsuzawa k-matsuzawa self-assigned this Oct 1, 2020
@k-matsuzawa k-matsuzawa added the Epic epic story item label Oct 1, 2020
@k-matsuzawa
Copy link
Collaborator Author

https://gcc.gnu.org/bugzilla/attachment.cgi?id=49276&action=diff
そもそも問題内容は、inline時にstrcmpと同じ扱いになるということらしい。
cfdでは基本的にstrncmp代替として使っていたから影響はない。
libwally-coreとsecp256k1の処理は影響がありそうなので、そちらは監視する。

@k-matsuzawa
Copy link
Collaborator Author

http://r6.ca/blog/20200929T023701Z.html
参考URL間違えてた。

@k-matsuzawa
Copy link
Collaborator Author

@k-matsuzawa
Copy link
Collaborator Author

全体的に、builtin memcmpを使わないことにした模様。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Epic epic story item
Projects
None yet
Development

No branches or pull requests

1 participant