Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add status code #16

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Conversation

muneebkq
Copy link
Collaborator

No description provided.

@ahmad-kemsan
Copy link
Collaborator

@muneebkq Why so many changes? Plus the error codes need to be added in the LexFloatStatusCodes.h as well.

Copy link
Collaborator

@ahmad-kemsan ahmad-kemsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@@ -114,7 +114,7 @@ enum LexFloatStatusCodes
/*
CODE: LF_E_METADATA_VALUE_LENGTH

MESSAGE: Metadata value length is more than 4096 characters.
MESSAGE: Metadata value length is more than 256 characters.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be 4096

*/
LF_E_MACHINE_FINGERPRINT = 66,


/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 67 error code as well


// Machine fingerprint has changed since activation.
LF_E_MACHINE_FINGERPRINT int = 66

// Client error.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 67 error code as well

Copy link
Collaborator

@ahmad-kemsan ahmad-kemsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@ahmad-kemsan ahmad-kemsan merged commit 46638a3 into borrowing-develop Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants