Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user metadata #19

Merged
merged 8 commits into from
Sep 19, 2024
Merged

feat: add user metadata #19

merged 8 commits into from
Sep 19, 2024

Conversation

muneebkq
Copy link
Collaborator

add metadata to user license payload

@muneebkq muneebkq requested a review from ahmad-kemsan August 28, 2024 07:23
@@ -35,16 +36,19 @@ pub type CallbackType = extern "C" fn(LexActivatorCode);
extern "C" {
// --------------- Setter Functions ---------------
pub fn SetProductData(productData: cstrtype!()) -> c_int;
pub fn SetProductFile(filePath: cstrtype!()) -> c_int;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq Remove this function, as we have deprecated SetProductFile(), so we will not include it in our rust wrapper.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

src/lib.rs Outdated
///
/// Returns `Ok(())` if mode is set successfully.

pub fn set_cache_mode(mode: bool) -> c_uint {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq Please follow the Result return pattern for set_cache_mode().

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jsdoc?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result pattern followed

Copy link
Collaborator

@ahmad-kemsan ahmad-kemsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@ahmad-kemsan
Copy link
Collaborator

@muneebkq To fix the windows build error, update the version of LexActivator to 3.30.0 in download.sh. It should fix the issue.

src/lib.rs Outdated
///
/// Returns `Ok(())` if the release version is set successfully, If an error occurs, an `Err` containing the `LexActivatorError`is returned.

pub fn set_app_version(app_version: String) -> Result<(), LexActivatorError> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq There is no need for adding set_app_version(). This function has been deprecated as we already have the set_release_version().

@@ -37,12 +38,13 @@ extern "C" {
pub fn SetProductData(productData: cstrtype!()) -> c_int;
pub fn SetProductId(productId: cstrtype!() , flags: c_uint) -> c_int;
pub fn SetDataDirectory(dataDir: cstrtype!()) -> c_int;
pub fn SetDebugMode(enable: c_uint) -> c_uint;
pub fn SetDebugMode(enable: c_uint) -> c_int;
pub fn SetCacheMode(mode: c_int) -> c_int;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@ahmad-kemsan ahmad-kemsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@ahmad-kemsan ahmad-kemsan merged commit b2ba7da into main Sep 19, 2024
4 checks passed
@ahmad-kemsan ahmad-kemsan deleted the muneeb/add-user-metadata branch September 19, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants