-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update yml and .env files #10
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
docker-compose.yml
Outdated
image: cryptlex/admin-portal:latest | ||
depends_on: | ||
- web-api | ||
env_file: web-portals.env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this file exist now?
.env
Outdated
@@ -10,6 +10,9 @@ [email protected] | |||
WEB_API_DOMAIN=cryptlex-api.mycompany.com | |||
DASHBOARD_DOMAIN=cryptlex-app.mycompany.com | |||
RELEASE_SERVER_DOMAIN=cryptlex-releases.mycompany.com | |||
ADMIN_PORTAL_DOMAIN=cryptlex-admin.mycompany.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admin-portal.mycompany.com
and similarly for others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adnan-kamili do we have to remove the dashboard.env file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about "WEB_API_DOMAIN" "DASHBOARD_DOMAIN" and "RELEASE_SERVER_DOMAIN"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need not be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adnan-kamili do we have to remove the dashboard.env file?
After customers migrate to the new portal, this file can be removed. In on-premise deployment docs we don't have to mention this file
…ustomer portal, and reseller portal
PR Type
Enhancement, Configuration changes
Description
.env
..github/workflows/pr_agent_codium.yml
.docker-compose.yml
.web-api.env
.Changes walkthrough 📝
.env
Add new domain environment variables
.env
reseller portals.
web-api.env
Add Google Analytics key environment variable
web-api.env
pr_agent_codium.yml
Add PR-Agent GitHub Actions workflow
.github/workflows/pr_agent_codium.yml
docker-compose.yml
Update PostgreSQL version and add new services
docker-compose.yml