Port from flow to Typescript #52

crucialfelix · 2019-07-05T15:13:41Z

Converts all files to .ts and changes the typing from flow annotations to TypeScript.

The library is now usable with JavaScript or TypeScript. When using VSCode you get intelligent error checking and auto-completion even when using JS.

The API remains the same. The published JS is the same interface. AFAICT nothing breaks.

Fixes #44

This will be reworked and cleaned up further

# This is the 1st commit message: Allocators # The commit message #2 will be skipped: # fixup! 1b99594

Turns off smoke test msg tests - typing eliminates those

dryadic library is not yet typed, so typing is not very strict here. Will rework this later.

crucialfelix · 2019-07-05T15:20:50Z

src/external.d.ts

@@ -0,0 +1,23 @@
+declare module "dryadic" {


dryadic will also be ported to Typescript. Afterwards this declaration file will be removed.

src/scapi.ts

crucialfelix · 2019-07-05T15:24:04Z

src/server/ServerPlus.ts

@@ -142,7 +140,7 @@ class Buffer {
  /**
   * Deallocate the Buffer, freeing memory on the server.
   */
-  free(): Promise<number> {


Old version was incorrectly typed. it returns void

crucialfelix · 2019-07-05T15:52:05Z

src/dryads/middleware/scserver.ts

+import { MsgType, CallAndResponse } from "../../Types";
+import Server from "../../server/server";
+
+interface Properties {}


What is this Properties? It's not really used here. Purpose is unclear.

…s missing This allows you to install from git source, not just from npm

Typescript esModuleInterop works fine for lodash

.prettierrc.js

src/Types.ts

src/dryads/AudioBus.ts

src/lang/sclang.ts

…parent

crucialfelix added 19 commits June 22, 2019 16:09

Move all src files to .ts

f937834

Switch tooling from babel to typescript

7ccfc08

WIP porting

82eea50

OSC types

8a4dc47

This will be reworked and cleaned up further

OSC messages

71bf064

Server options

3c320e4

Port sclang-io

13e79b4

Allocators

1b99594

# This is a combination of 2 commits.

57f05e4

# This is the 1st commit message: Allocators # The commit message #2 will be skipped: # fixup! 1b99594

sclang

6ec5027

Server type fixes

843d2ba

Turns off smoke test msg tests - typing eliminates those

sclang tests

8e549df

Dryads

3b9f267

utils

023ee58

dryads

feebdb5

dryadic library is not yet typed, so typing is not very strict here. Will rework this later.

Server fixes

3d4bbb5

fix Store: supply a notSetValue of new Map when mutating

26661f7

Dryad test fixes

bb3b337

SCLang test fixes

29388f2

crucialfelix commented Jul 5, 2019

View reviewed changes

src/scapi.ts Outdated Show resolved Hide resolved

crucialfelix commented Jul 5, 2019

View reviewed changes

crucialfelix added 7 commits July 5, 2019 19:22

Use built in Partial instead of self defined Optional

67caade

Define synthDesc type

f216404

Fix OSCSched Event type vs OSCEvent

a5ce75f

fix imports

ea9ba16

Disable some errors for estlint

c1699fe

Remove flow declarations

ba96291

Fix dryads index : array of types, not instances

67cd6c8

crucialfelix added 3 commits July 5, 2019 19:22

scripts: reinstate copy .sc files on build, build on install if lib i…

a641e40

…s missing This allows you to install from git source, not just from npm

Import _ from lodash

ae98a0e

Typescript esModuleInterop works fine for lodash

Convert to async functions

0931a25

crucialfelix force-pushed the feature/flow-to-typescript branch from 8e893a0 to 0931a25 Compare July 5, 2019 17:27

Use fs promises and async functions to clean up some pyramids

9a70a61

crucialfelix commented Jul 5, 2019

View reviewed changes

.prettierrc.js Show resolved Hide resolved

crucialfelix commented Jul 5, 2019

View reviewed changes

src/Types.ts Show resolved Hide resolved

crucialfelix commented Jul 5, 2019

View reviewed changes

src/dryads/AudioBus.ts Outdated Show resolved Hide resolved

crucialfelix commented Jul 5, 2019

View reviewed changes

src/lang/sclang.ts Show resolved Hide resolved

crucialfelix added 5 commits July 6, 2019 16:18

Move types from Types.ts into packages

40fbe33

fix: duplication. should only set it in the constructor

c8fe224

Dryads: consistent use of Properties and pass it as type variable to …

2e091cb

…parent

Keep sclang includePaths/excludePaths options backwards compatible

1eefc65

Fix: Synth params may contain Dryads

7b4914e

crucialfelix force-pushed the feature/flow-to-typescript branch from e516c89 to 7b4914e Compare July 6, 2019 17:34

crucialfelix merged commit 7bf3fdf into develop Jul 6, 2019

crucialfelix deleted the feature/flow-to-typescript branch October 20, 2019 16:10

crucialfelix added the enhancement label Nov 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port from flow to Typescript #52

Port from flow to Typescript #52

crucialfelix commented Jul 5, 2019 •

edited

Loading

crucialfelix Jul 5, 2019

crucialfelix Jul 5, 2019 •

edited

Loading

crucialfelix Jul 5, 2019

Port from flow to Typescript #52

Port from flow to Typescript #52

Conversation

crucialfelix commented Jul 5, 2019 • edited Loading

crucialfelix Jul 5, 2019

Choose a reason for hiding this comment

crucialfelix Jul 5, 2019 • edited Loading

Choose a reason for hiding this comment

crucialfelix Jul 5, 2019

Choose a reason for hiding this comment

crucialfelix commented Jul 5, 2019 •

edited

Loading

crucialfelix Jul 5, 2019 •

edited

Loading