Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translators to Co-Authored-By #35

Open
TurnrDev opened this issue Oct 1, 2020 · 6 comments
Open

Add translators to Co-Authored-By #35

TurnrDev opened this issue Oct 1, 2020 · 6 comments
Labels
API limitation Currently, this is not possible due to API limitations enhancement New feature or request

Comments

@TurnrDev
Copy link

TurnrDev commented Oct 1, 2020

Is your feature request related to a problem? Please describe.
When a translation PR comes through, it's attributed to just Crowdin Bot, which is a tad unfair on the actual translators.

Describe the solution you'd like
Use Co-Authored-By to attribute the actual people who worked on the translations.

Describe alternatives you've considered
Using the Last-Translator flag on the file, but that only attributes the latest author

Additional context
Translators are just as important to a project as a Developer is, by making use of the Co-Authored-By feature in git, we can give them some credit for their work.

@TurnrDev TurnrDev added the enhancement New feature or request label Oct 1, 2020
@jesec
Copy link

jesec commented Jan 29, 2021

Totally agree.

Weblate already has the feature: firewalld/firewalld#697, Radarr/Radarr@aafd82b.

Translators from the community are entitled to be properly recognized and attributed. Without such a feature, a human would be needed to lookup, review and compile a list of contributors, which is time-consuming and slows the translation acceptance process.

@VBeytok VBeytok self-assigned this Feb 1, 2021
@NickVolynkin
Copy link

NickVolynkin commented May 12, 2021

The problem here is that we need to know the translators' emails that they've added to their GitHub accounts. These can be different from the emails known to Crowdin. Also, this is a kind of personal info disclosure, so we'll need to ask for permission to put their name & email in the commit message and then store it somewhere in Crowdin.

Anyway, I'll be happy to see this feature at least in the Crowdin API and CLI.

@TurnrDev
Copy link
Author

TurnrDev commented May 27, 2021

The problem here is that we need to know the translators' emails that they've added to their GitHub accounts

Not a problem, just use the one they use for Crowdin. It's about attribution, not GitHub itself.

Also, this is a kind of personal info disclosure, so we'll need to ask for permission to put their name & email in the commit message

I mean, a generic "Allow the project manager to attribute my name and email on external services" setting on Crowdin would be good. I'm sure most project managers want to attribute translators anyway?

@andrii-bodnar andrii-bodnar added the API limitation Currently, this is not possible due to API limitations label Apr 7, 2022
@uiolee
Copy link

uiolee commented Sep 7, 2023

agree

@rickstaa
Copy link

rickstaa commented Dec 13, 2023

Having this feature would significantly enhance user interaction 🚀. When receiving translations, I ask the translators to provide their GitHub usernames in the chat. However, we could streamline this process by implementing an opt-in system where users link their GitHub accounts. If a GitHub account is connected, it could automatically include their account as a co-author.

It's worth noting that I haven't explored whether their GitHub email addresses are accessible to third-party services in this manner. Typically, I retrieve this information by adding the .patch suffix to one of the user's commits, such as this commit.

@anatawa12
Copy link

I think it's better to use Author attribute of git commit if there is only one related author since it's git-builtin.
In git, we can specify different Author than Committer so I think it's good to specify bot as a committer and author as translator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API limitation Currently, this is not possible due to API limitations enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants