Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Unit tests for the reports package #195

Closed
andrii-bodnar opened this issue Sep 28, 2023 · 8 comments · Fixed by #244
Closed

Add more Unit tests for the reports package #195

andrii-bodnar opened this issue Sep 28, 2023 · 8 comments · Fixed by #244
Assignees
@DecarteAdam
Labels
good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest

Comments

@andrii-bodnar
Copy link
Member

The reports package has low code coverage by Unit tests. We need to add more Unit tests to cover the code.

References:
@andrii-bodnar andrii-bodnar added good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest labels Sep 28, 2023
@chinmaym07
Copy link

Hey @andrii-bodnar , can I contribute to this ?

@andrii-bodnar
Copy link
Member Author

@chinmaym07 sure, thank you!

@andrii-bodnar
Copy link
Member Author

Hi @chinmaym07, any updates on this?

@innomaxx innomaxx self-assigned this Oct 23, 2023
@DecarteAdam
Copy link
Contributor

Hi!
What is expected code coverage?

@andrii-bodnar
Copy link
Member Author

@DecarteAdam I think that around 80-90% for models would be good

@DecarteAdam
Copy link
Contributor

Hey @andrii-bodnar
Can you assign this to me?
Thanks

@DecarteAdam
Copy link
Contributor

Hey @andrii-bodnar
Pushed!
Can you link this issue to my PR?

@andrii-bodnar andrii-bodnar linked a pull request May 6, 2024 that will close this issue
test: improve 'report' package code coverage #244
Merged
@andrii-bodnar
Copy link
Member Author

Hey @DecarteAdam, thank you!

Will review it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DecarteAdam DecarteAdam

Labels
good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve 'report' package code coverage DecarteAdam/crowdin-api-client-java
4 participants
@andrii-bodnar @innomaxx @DecarteAdam @chinmaym07