From cb43a4587a4244fa994a466ece3cbe7022defb4e Mon Sep 17 00:00:00 2001 From: Andrii Bodnar Date: Wed, 26 Jul 2023 09:21:51 +0300 Subject: [PATCH] fix: 'unassignLabelFromStrings' - 'stringIds' parameter --- src/main/java/com/crowdin/client/labels/LabelsApi.java | 9 +++++++-- .../java/com/crowdin/client/labels/LabelsApiTest.java | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/crowdin/client/labels/LabelsApi.java b/src/main/java/com/crowdin/client/labels/LabelsApi.java index 6c752d4f8..ac4a90427 100644 --- a/src/main/java/com/crowdin/client/labels/LabelsApi.java +++ b/src/main/java/com/crowdin/client/labels/LabelsApi.java @@ -133,15 +133,20 @@ public ResponseList assignLabelToStrings(Long projectId, Long labe /** * @param projectId Project Identifier * @param labelId Label Identifier + * @param stringIds List of string IDs * @return Source string * @see */ - public ResponseList unassignLabelFromStrings(Long projectId, Long labelId) throws HttpException, HttpBadRequestException { + public ResponseList unassignLabelFromStrings(Long projectId, Long labelId, List stringIds) throws HttpException, HttpBadRequestException { String builtUrl = String.format("%s/projects/%d/labels/%d/strings", this.url, projectId, labelId); - SourceStringResponseList response = this.httpClient.delete(builtUrl, new HttpRequestConfig(), SourceStringResponseList.class); + Map> queryParams = HttpRequestConfig.buildUrlParams( + "stringIds", Optional.ofNullable(stringIds == null ? null : stringIds.stream().map(String::valueOf).collect(Collectors.joining(",")) + )); + + SourceStringResponseList response = this.httpClient.delete(builtUrl, new HttpRequestConfig(queryParams), SourceStringResponseList.class); return SourceStringResponseList.to(response); } diff --git a/src/test/java/com/crowdin/client/labels/LabelsApiTest.java b/src/test/java/com/crowdin/client/labels/LabelsApiTest.java index cc306218a..f2c2aac52 100644 --- a/src/test/java/com/crowdin/client/labels/LabelsApiTest.java +++ b/src/test/java/com/crowdin/client/labels/LabelsApiTest.java @@ -118,7 +118,7 @@ public void assignLabelToStringTest() { @Test public void unassignLabelToStringTest() { - ResponseList response = this.getLabelsApi().unassignLabelFromStrings(projectId, labelId); + ResponseList response = this.getLabelsApi().unassignLabelFromStrings(projectId, labelId, Arrays.asList(1L, 2L)); assertEquals(1, response.getData().size()); }