Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgotten nodes are still referenced in proposals #8

Open
2 of 3 tasks
vuntz opened this issue Feb 20, 2017 · 4 comments · May be fixed by crowbar/crowbar-core#1116
Open
2 of 3 tasks

Forgotten nodes are still referenced in proposals #8

vuntz opened this issue Feb 20, 2017 · 4 comments · May be fixed by crowbar/crowbar-core#1116
Assignees
@tpatzig @mkoderer
Labels
major

Comments

@vuntz
Copy link

vuntz commented Feb 20, 2017 •
edited by matelakat
Loading

This creates some confusion, and can also lead to errors (when not using the webui when applying a proposal, since only the webui will remove the node automatically).

The Pull request that fixes this issue is here: #36

  • tested
  • reviewed by SUSE
  • reviewed by SAP
@vuntz vuntz self-assigned this Feb 20, 2017
vuntz added a commit to vuntz/crowbar-core that referenced this issue Feb 20, 2017
@vuntz
crowbar: Remove forgotten nodes from proposals
cf0e0a0 
Forgotten nodes are not removed from existing proposals (applied and
non-applied). While the webui removes non-existing nodes when displaying
a proposal, if only the API is used, applying a proposal with such
non-existing nodes may result in failures.

Closes sap-oc#8
@vuntz vuntz linked a pull request Feb 20, 2017 that will close this issue
Open
@vuntz
Copy link
Author

vuntz commented Feb 20, 2017

There's a first easy step that can be done here (see the PR above); however the question is whether the proposals should be marked as "please double-check me" in the UI. For instance, removing the only nova-controller node clearly results in something non-functional and we should maybe tell the user about it...

Any opinion?

vuntz added a commit to vuntz/crowbar-core that referenced this issue Feb 20, 2017
@vuntz
crowbar: Remove forgotten nodes from proposals
a31a710 
Forgotten nodes are not removed from existing proposals (applied and
non-applied). While the webui removes non-existing nodes when displaying
a proposal, if only the API is used, applying a proposal with such
non-existing nodes may result in failures.

Closes sap-oc#8
@vuntz vuntz mentioned this issue Jun 2, 2017
Closed
@matelakat matelakat self-assigned this Jun 2, 2017
@matelakat
Copy link

Creating a backport...

@matelakat matelakat mentioned this issue Jun 2, 2017
Open
@matelakat
Copy link

Our backport here: #36

@mkoderer mkoderer added the major label Jun 8, 2017
@matelakat
Copy link

matelakat commented Jun 15, 2017 •
edited
Loading

Doing a manual test on this change:

  • install SAP current mkcloud
  • remove a node through CLI
root@crowbar:~ # crowbarctl node delete d52-54-77-77-01-04.virtual.cloud.suse.de
Successfully triggered delete for d52-54-77-77-01-04.virtual.cloud.suse.de
  • see that the node is still listed
root@crowbar:~/remove-forgotten-nodes # crowbarctl proposal show --json network default | grep d52-54-77-77-01-04.virtual.cloud.suse.de
          "d52-54-77-77-01-04.virtual.cloud.suse.de",

Install fix

  • remove a node through CLI
crowbarctl node delete d52-54-77-77-01-03.virtual.cloud.suse.de
  • see that the node is not listed
root@crowbar:~/remove-forgotten-nodes # crowbarctl proposal show --json network default | grep d52-54-77-77-01-03.virtual.cloud.suse.de || echo "not found"
not found

(this test scenario will be refined by adding specific commands as I run them)

@matelakat matelakat assigned vuntz, tpatzig and mkoderer and unassigned matelakat and vuntz Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpatzig tpatzig

@mkoderer mkoderer

Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crowbar: Remove forgotten nodes from proposals vuntz/crowbar-core
4 participants
@tpatzig @matelakat @vuntz @mkoderer