Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #882 has created new problem #885

Open
refdoc opened this issue Apr 15, 2018 · 4 comments
Open

Fix #882 has created new problem #885

refdoc opened this issue Apr 15, 2018 · 4 comments

Comments

@refdoc
Copy link
Contributor

refdoc commented Apr 15, 2018

As result of #882 the crashes are now avoided but both the scroll down menu for book names and the chapter choser are misplaced

(Debian stretch)

@karlkleinpaste
Copy link
Contributor

karlkleinpaste commented Apr 15, 2018

the entirety of the change for #882 is to replace "0,0" pairs in menu popups with GDK gravity indicators, e.g.:

-               gtk_menu_popup_at_widget(GTK_MENU(menu), widget, 0, 0, NULL);
+               gtk_menu_popup_at_widget(GTK_MENU(menu), widget, GDK_GRAVITY_SOUTH_WEST, GDK_GRAVITY_NORTH_WEST, NULL);

how can this possibly have had the slightest effect on chooser placement? are we looking at an actual xiphos problem, or instead a GTK or Wayland problem?

@karlkleinpaste
Copy link
Contributor

i hate the github editor. i hate it, hate it, hate it.
those 2 lines were the '-'/'+' lines of "git diff" of one example use of gtk_menu_popup_at_widget.

@greg-hellings
Copy link
Contributor

@karlkleinpaste I've updated your comment to properly show and highlight that as a patch diff.

@refdoc
Copy link
Contributor Author

refdoc commented Apr 17, 2018

Ok some more info re what is happening:

The three drop down menus (book name, chapter no, verse no) will, if too long move to the left edge of the Xiphos window. So, if a chapter e.g. has only 10 verses the drop down menu will be in the usual and normal place. If a book has only 10 chapters, same. But if a book has a lot of chapters or a chapter lots of verses then the menu will detach and hang on the edge of Xiphos' window.

The terminal printout is
(xiphos:2283): Gdk-CRITICAL **: 20:39:58.002: gdk_window_get_window_type: assertion 'GDK_IS_WINDOW (window)' failed

I think what is happening is that this particular set of menus are a bit cobbled together and are not using standard menu widgets. And this worked so far, but is now causing grief.

From one of the files a commentary:
\* Description
\* make the tooglebutton act like a gtk optionmenu by dropping a popup
\* under the button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants