diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 782411f..3b2e9c7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,13 +13,7 @@ env: GO_VERSION: '1.20' GOLANGCI_VERSION: 'v1.53.3' DOCKER_BUILDX_VERSION: 'v0.8.2' - - # Common users. We can't run a step 'if secrets.AWS_USR != ""' but we can run - # a step 'if env.AWS_USR' != ""', so we copy these to succinctly test whether - # credentials have been provided before trying to run steps that need them. XPKG_ACCESS_ID: ${{ secrets.XPKG_ACCESS_ID }} - DOCKER_USR: ${{ secrets.DOCKER_USR }} - AWS_USR: ${{ secrets.AWS_USR }} jobs: detect-noop: @@ -243,13 +237,6 @@ jobs: username: ${{ secrets.XPKG_ACCESS_ID }} password: ${{ secrets.XPKG_TOKEN }} - - name: Login to Docker - uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20 # v3 - if: env.DOCKER_USR != '' - with: - username: ${{ secrets.DOCKER_USR }} - password: ${{ secrets.DOCKER_PSW }} - - name: Publish Artifacts run: make publish BRANCH_NAME=${GITHUB_REF##*/} if: env.XPKG_ACCESS_ID != '' diff --git a/Makefile b/Makefile index a2c69b2..dd21023 100644 --- a/Makefile +++ b/Makefile @@ -63,7 +63,7 @@ IMAGES = $(PROJECT_NAME) # ==================================================================================== # Setup XPKG -XPKG_REG_ORGS ?= xpkg.upbound.io/crossplane-contrib index.docker.io/crossplanecontrib +XPKG_REG_ORGS ?= xpkg.upbound.io/crossplane-contrib # NOTE(hasheddan): skip promoting on xpkg.upbound.io as channel tags are # inferred. XPKG_REG_ORGS_NO_PROMOTE ?= xpkg.upbound.io/crossplane-contrib