Hey @danielinclouds, thanks for opening this PR!

You just need to rebase your commits signing each of them (git commit -s), otherwise the DCO CI check will fail.

I've added some small comments in the code.

I did some testing running the code and that's what I think should be fixed:

• Import is not working.
• Import isn't importing the private networks.

I think the one of the errors are occurring because I told you in the last review to remove some fields from the LateInitialize method. I'm sorry if this is the cause, I didn't predict it.

The first error you can reproduce with this test case:

1. Create a DNS zone in the GCP interface

2. Create a ManagedZone managed resource only with required fields with the same name as created in the step 1.

apiVersion: dns.gcp.crossplane.io/v1alpha1
kind: ManagedZone
metadata:
  name: test
spec:
  forProvider:
    dnsName: test.com.
  providerConfigRef:
    name: default

3. Results in a error, because it is trying to update the visibility to public (it was created as private in the interface). The expected behavior would be importing the values from the API and not updating the resource at all (because that would be nothing to update, as we are importing the fields from the API.

1.6639251312905607e+09	DEBUG	provider-gcp	Reconciling	{"controller": "managed/managedzone.dns.gcp.crossplane.io", "request": "/test"}
1.6639251331243162e+09	DEBUG	provider-gcp	Cannot update external resource	{"controller": "managed/managedzone.dns.gcp.crossplane.io", "request": "/test", "uid": "ad15a248-58ca-47d1-90f3-22a51a8062e6", "version": "53015", "external-name": "test"}
1.663925133124595e+09	DEBUG	events	Warning	{"object": {"kind":"ManagedZone","name":"test","uid":"ad15a248-58ca-47d1-90f3-22a51a8062e6","apiVersion":"dns.gcp.crossplane.io/v1alpha1","resourceVersion":"53015"}, "reason": "CannotUpdateExternalResource", "message": "googleapi: Error 400: The field 'entity.managedZone.visibility' cannot be modified., immutableField"}

To see the second error, you can create an ManagedZone without specifying the networks, and then you specify it in the GCP interface.

What happens is that the controller isn't considering this field, and the controller is behaving as it is already up to date with the external state (and it isn't).

The expected behavior would be: after specifying in the GCP interface, in the next reconciliation loop the network would be filled when kubectl describe the resource.

Looks great! We are pretty close to merge, thanks for your effort!

I created the manifest:

apiVersion: compute.gcp.crossplane.io/v1beta1
kind: Network
metadata:
  name: example
spec:
  forProvider:
    autoCreateSubnetworks: false
    routingConfig:
      routingMode: REGIONAL

---
apiVersion: dns.gcp.crossplane.io/v1alpha1
kind: ManagedZone
metadata:
  name: test
spec:
  forProvider:
    dnsName: test.com.
    visibility: private
    privateVisibilityConfig:
      networks:
      - networkRef: 
          name: example

And I got an update loop in the managed resource. Every reconciliation it was updating, even if not needed.

Besides that, I added some small comments in the code.