Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argocd application creation fails #136

Closed
aslamkhan138 opened this issue Jan 29, 2024 · 12 comments
Closed

Argocd application creation fails #136

aslamkhan138 opened this issue Jan 29, 2024 · 12 comments
Labels
bug Something isn't working stale

Comments

@aslamkhan138
Copy link

aslamkhan138 commented Jan 29, 2024

What happened?

Argocd application creation fails with error observe failed: cannot list Argocd application: rpc error: code = NotFound desc = application 'example-application-kubeconfig' not found

How can we reproduce it?

Apply this manifest https://github.com/crossplane-contrib/provider-argocd/blob/release-0.5/examples/application/application.yaml.

What environment did it happen in?

Crossplane version: v0.39.0
Crossplane Provider argocd version: v0.5.0

I see we are hitting this: https://github.com/crossplane-contrib/provider-argocd/blob/release-0.5/pkg/controller/applications/controller.go#L113. Ideally, do we need to set nil instead of error there?

@aslamkhan138 aslamkhan138 added the bug Something isn't working label Jan 29, 2024
@aslamkhan138
Copy link
Author

aslamkhan138 commented Jan 29, 2024

@maximilianbraun @janwillies - Is this something you can help me out with?

@MisterMX
Copy link
Collaborator

This seems to be a permission error that is returned by Argocd if a List call returns no results. That is strange because it is supposed to return an empty list if no application matches the query.

Which Argocd version are you using? And can you try it with provider-argocd v0.6.0?

@aslamkhan138
Copy link
Author

This seems to be a permission error that is returned by Argocd if a List call returns no results. That is strange because it is supposed to return an empty list if no application matches the query.

Which Argocd version are you using? And can you try it with provider-argocd v0.6.0?

I tried it and it returns same

2024-02-01T09:26:56Z	DEBUG	provider-argocd	Cannot observe external resource	{"controller": "managed/application", "request": "/example-application-kubeconfig", "uid": "2a4781f0-eb47-4841-80c1-7c35f6141289", "version": "88623982", "external-name": "example-application-kubeconfig", "error": "cannot list Argocd application: rpc error: code = NotFound desc = application 'example-application-kubeconfig' not found", "errorVerbose": "rpc error: code = NotFound desc = application 'example-application-kubeconfig' not found\ncannot list Argocd application\ngithub.com/crossplane-contrib/provider-argocd/pkg/controller/applications.(*external).Observe\n\tgithub.com/crossplane-contrib/provider-argocd/pkg/controller/applications/controller.go:113\ngithub.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile\n\tgithub.com/crossplane/[email protected]/pkg/reconciler/managed/reconciler.go:780\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:122\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:323\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235\nruntime.goexit\n\truntime/asm_amd64.s:1594"}
2024-02-01T09:26:56Z	DEBUG	events	cannot list Argocd application: rpc error: code = NotFound desc = application 'example-application-kubeconfig' not found	{"type": "Warning", "object": {"kind":"Application","name":"example-application-kubeconfig","uid":"2a4781f0-eb47-4841-80c1-7c35f6141289","apiVersion":"applications.argocd.crossplane.io/v1alpha1","resourceVersion":"88623982"}, "reason": "CannotObserveExternalResource"}

@maximilianbraun
Copy link
Contributor

@aslamkhan138 which argocd version do you ahve deployed?

@aslamkhan138
Copy link
Author

@aslamkhan138 which argocd version do you ahve deployed?

I have tried on both v0.5.0 and v0.6.0

@maximilianbraun
Copy link
Contributor

@aslamkhan138 and which version of argo-cd itself are you running?

@aslamkhan138
Copy link
Author

argo-cd

@maximilianbraun - argocd version : v2.6.7+5bcd846

Copy link

github-actions bot commented May 6, 2024

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 7 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label May 6, 2024
@maximilianbraun
Copy link
Contributor

/fresh

@github-actions github-actions bot removed the stale label May 6, 2024
Copy link

github-actions bot commented Aug 5, 2024

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 7 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Aug 5, 2024
@maximilianbraun
Copy link
Contributor

/fresh

@github-actions github-actions bot removed the stale label Aug 5, 2024
Copy link

github-actions bot commented Nov 4, 2024

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 7 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

3 participants