Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying protocol in environment for Dashboard API host #1

Open
taylor opened this issue Apr 9, 2019 · 0 comments
Open

Support specifying protocol in environment for Dashboard API host #1

taylor opened this issue Apr 9, 2019 · 0 comments

Comments

@taylor
Copy link
Contributor

taylor commented Apr 9, 2019

Currently the DASHBOARD_API_HOST_PORT only supports the hostname and port. The protocol is hardcoded to HTTPS and when HTTP is desired for internal dev use that needs to be updated in the code. Ideally the protocol can be switched using the same environment variable.

If the protocol is not specified it would default to HTTPS otherwise it will use what is set in the environment variable DASHBOARD_API_HOST_PORT

Examples:
@taylor taylor mentioned this issue Apr 9, 2019
Closed
taylor added a commit that referenced this issue Apr 9, 2019
@taylor
Support setting URI scheme via DASHBOARD_API_HOST_PORT
7f1e557 
- Default to https for URI scheme
  * example `export DASHBOARD_API_HOST_PORT=devapi.cncf.ci`
- If the environment variable DASHBOARD_API_HOST_PORT contains http or
https then that scheme will be used
  * example `export DASHBOARD_API_HOST_PORT=http://devapi.cncf.ci`

[#1, crosscloudci/crosscloudci#114]
@taylor taylor mentioned this issue Apr 9, 2019
Merged
taylor added a commit that referenced this issue Apr 9, 2019
@taylor
fix uri require [#1]
f817bac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taylor