From b1cec4931364ef0a689ece08df8b58eafea66856 Mon Sep 17 00:00:00 2001 From: Alessandro Manfredi Date: Thu, 13 Jun 2024 16:56:13 +0200 Subject: [PATCH] fix(upgradeable_contracts): adds missing abi.encodePacked --- contracts/upgradeable_contracts/BasicBridge.sol | 2 +- contracts/upgradeable_contracts/HashiManager.sol | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contracts/upgradeable_contracts/BasicBridge.sol b/contracts/upgradeable_contracts/BasicBridge.sol index e4e4c000..dcd2822d 100644 --- a/contracts/upgradeable_contracts/BasicBridge.sol +++ b/contracts/upgradeable_contracts/BasicBridge.sol @@ -116,7 +116,7 @@ contract BasicBridge is chainId == manager.targetChainId() && sender == manager.targetAddress() && threshold == manager.expectedThreshold() && - keccak256(adapters) == manager.expectedAdaptersHash() + keccak256(abi.encodePacked(adapters)) == manager.expectedAdaptersHash() ); } } diff --git a/contracts/upgradeable_contracts/HashiManager.sol b/contracts/upgradeable_contracts/HashiManager.sol index b4f57f76..ece8019c 100644 --- a/contracts/upgradeable_contracts/HashiManager.sol +++ b/contracts/upgradeable_contracts/HashiManager.sol @@ -44,7 +44,7 @@ contract HashiManager is InitializableBridge, Ownable { } function setExpectedAdaptersHash(address[] adapters_) external onlyOwner { - uintStorage[EXPECTED_ADAPTERS_HASH] = uint256(keccak256(adapters_)); + uintStorage[EXPECTED_ADAPTERS_HASH] = uint256(keccak256(abi.encodePacked(adapters_))); } function expectedThreshold() external view returns (uint256) {