Wrong loading order of Modules generated by Core\Application

[TiSiE]

YAWIK/module/Core/src/Application.php

Lines 72 to 80 in 911e586

	public static function generateModuleConfiguration($loadModules=[])
	{
	$modules = ArrayUtils::merge(
	static::getRequiredModules(),
	static::scanAdditionalModule()
	);
	$modules = ArrayUtils::merge($modules, $loadModules);
	return $modules;
	}

This will produce DependencyCheck errors, because additional modules will be loaded BEFORE the YAWIK modules.

In particular, when using yawik/JobsByMail, an exception occurs, because JobsByMail requires the Jobs module.

To get the ordering right, this might be a better approach:

    public static function generateModuleConfiguration($loadModules=[]) 
     { 
         $modules = array_merge( 
             static::getRequiredModules(), 
             $loadModules,
             static::scanAdditionalModule() 
         ); 

         return $modules; 
     } 

[TiSiE]

I forgot something:

YAWIK/module/Core/src/Application.php

Lines 158 to 163 in 911e586

	if (strpos($addModule, '-') === 0) {
	$remove = substr($addModule, 1);
	$modules = array_filter($modules, function ($elem) use ($remove) {
	return strcasecmp($elem, $remove);
	});
	} else {

This code was meant to allow to remove modules from the list prior to loading, but it is completely useless in this position, because the list of all modules is not generated at this point in the code execution.

[kilip]

@TiSiE I will try to use DependencyIndicatorInterface in Organizations module, I hope this can make zf3 component installer making modules config in spesific order in yawik/standard:

/**
 * Bootstrap class of the organizations module
 */
class Module implements BootstrapListenerInterface, DependencyIndicatorInterface
{
    public function getModuleDependencies()
    {
        return [
            'Core',
            'Auth',
        ];
    }
}

I hope this can fix issue like #507 in future, because it will raise an error if Organization module loaded before Core or Auth module

I will fix that ordering issue in next pull request.

This code was meant to allow to remove modules from the list prior to loading, but it is completely useless in this position, because the list of all modules is not generated at this point in the code execution.

What about this issue? Can we delete this scanAdditionalModule function or you have any suggestion to fix this?

[TiSiE]

What about this issue? Can we delete this scanAdditionalModule function or you have any suggestion to fix this?

See yawik/standard#3