Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unblock rooms when any authority rejects #84

Closed
wants to merge 5 commits into from

Conversation

nids98
Copy link
Member

@nids98 nids98 commented Jan 30, 2019

Description

When an authority rejects the booking the room gets unblocked.
Fixes #66

Type of Change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Copy link
Member

@bhawesh96 bhawesh96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about writing a function to put the repetitive logic there?

let dateRef = roomRef.child(date)
dateRef.on('value', function (snapshot) {
let roomsThatDay = snapshot.val()
for (let j = 0; j < eventrooms.length; j++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using forEach()?

@nids98 nids98 closed this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Once event is rejected unblock corresponding rooms
2 participants