Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update travis config for PR #52

Open
bhawesh96 opened this issue Dec 26, 2018 · 2 comments
Open

Update travis config for PR #52

bhawesh96 opened this issue Dec 26, 2018 · 2 comments
Assignees
@bhawesh96
Labels
bug Something isn't working difficulty/medium This issue has moderate difficulty discussion needed importance/high This issue is of high importance

Comments

@bhawesh96
Copy link
Member

Describe the bug
The before_install script fails for PRs as one is not able to decrypt secrets.tar.enc. It'll work only for me as it uses my encryption keys.

To Reproduce
Steps to reproduce the behavior:

  1. Submit/update a PR

Expected behavior
Staging environment variables are used for PRs. These variables will have to be provided in travis environment variables manually.
@bhawesh96 bhawesh96 added bug Something isn't working difficulty/medium This issue has moderate difficulty importance/high This issue is of high importance labels Dec 26, 2018
@rsarky rsarky removed their assignment Apr 7, 2020
@rsarky
Copy link
Member

rsarky commented Apr 7, 2020

This is sort of difficult to handle.
The optimal case would have been if we had a test suite to check for regressions on a new PR and block from merging if some test breaks.
A test suite has been on the cards for a long time now, need someone to pick this up

@bhawesh96
Copy link
Member Author

I'll take this up.
I'll see if Github Actions can be used. Else, travis should have something.
Let me get back with feasible options and we can discuss.

@bhawesh96 bhawesh96 self-assigned this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhawesh96 bhawesh96

Labels
bug Something isn't working difficulty/medium This issue has moderate difficulty discussion needed importance/high This issue is of high importance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhawesh96 @rsarky