Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disney edition #42

Open
diomed opened this issue Jun 15, 2023 · 3 comments
Open

Disney edition #42

diomed opened this issue Jun 15, 2023 · 3 comments

Comments

@diomed
Copy link

diomed commented Jun 15, 2023

black and white.md
Hello

I found Disney edition of CAH and turned it into json file

I wanted to do PR, but I dont know about metadata numbers part and is everything of this correct.
So I made a gist, since its a few lines of code, and you could check it and integrate it into existing project.

cheers!

https://gist.github.com/diomed/0131add377d0912e411d94d3d92b8631

@crhallberg
Copy link
Owner

Hey! Thanks for reaching out!

It looks likes these cards are part of a pack available on Etsy called Cards Against Your Childhood I'll be able to add these to the database by tweaking my script, but I want to look into why they didn't include these cards in the Master List.

@crhallberg
Copy link
Owner

Looking into it more, it looks like the sheet I use to generate all the cards has changed the way they organize things a bit. I'll have to adjust the import script. When I do, these cards and their 1,094 siblings will be included!

@diomed
Copy link
Author

diomed commented Jun 18, 2023

excellent. i actually had this for about a year and so on pc and forgot about it, now I found it and decided to share.

hopefully it'll get implemented soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants