Skip to content

Add "pid management" code to vfkit/the client API? #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cfergeau opened this issue Mar 10, 2025 · 3 comments · May be fixed by #293
Open

Add "pid management" code to vfkit/the client API? #278

cfergeau opened this issue Mar 10, 2025 · 3 comments · May be fixed by #293
Assignees
@vyasgun

Comments

@cfergeau
Copy link
Collaborator

This came up here kubernetes/minikube#20506 (comment)
@nirs
Copy link
Contributor

nirs commented Mar 10, 2025

I think this is not only the pid management code, but vfkit can provide a library to run the vfkit process. Many clients need to build the command line arguments, run the process, monitor the state, and stop it. Having the vfkit library will make this easier to integrate correctly.

@cfergeau cfergeau mentioned this issue Mar 12, 2025
Merged
@cfergeau
Copy link
Collaborator Author

For reference, kubernetes/minikube#20501 has some pidfile code. crc also has code searching for the vfkit process, ... which should be similar.

@nirs
Copy link
Contributor

nirs commented Mar 14, 2025

@cfergeau Please check kubernetes/minikube#20528, it can be reused in vfkit.

@vyasgun vyasgun self-assigned this Apr 2, 2025
@vyasgun vyasgun moved this to Work In Progress in Project planning: crc Apr 2, 2025
@vyasgun vyasgun moved this from Work In Progress to Ready for review in Project planning: crc Apr 30, 2025
@vyasgun vyasgun linked a pull request May 7, 2025 that will close this issue
Open
@afbjorklund afbjorklund mentioned this issue May 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vyasgun vyasgun

Labels
None yet
Projects
Project planning: crc
Status: Ready for review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a Process struct for managing processes by pid file vyasgun/vfkit
3 participants
@nirs @cfergeau @vyasgun