Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SimpleHttpFetcher.finalize() method #35

Open
aecio opened this issue Aug 20, 2023 · 0 comments
Open

Remove SimpleHttpFetcher.finalize() method #35

aecio opened this issue Aug 20, 2023 · 0 comments

Comments

@aecio
Copy link
Collaborator

aecio commented Aug 20, 2023

Overriding the Object::finalize() method is deprecated since Java 9, and should be removed. One option would be to replace it with a close() method and make SimpleHttpFetcher implement the Closeable interface.

Current finalize() implementation:

    @Override
    protected void finalize() {
        monitor.interrupt();
        _connectionManager.shutdown();
        IOUtils.closeQuietly(_httpClient);
        _httpClient = null;
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant