Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cratedb_sqlparse from javascript to typescript #52

Closed
alexdametto opened this issue Jul 5, 2024 · 1 comment
Closed

Migrate cratedb_sqlparse from javascript to typescript #52

alexdametto opened this issue Jul 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request javascript About the Javascript package

Comments

@alexdametto
Copy link
Contributor

Right now cratedb_sqlparse does not support typescript, so every typescript project that wants to use this library needs to define their own types, leading to possible type error(s). We should migrate it to typescript (since it is also compatible with plain javascript).

@surister
Copy link
Collaborator

surister commented Jul 5, 2024

Honestly I have never liked the typescript DX, I would much rather generate the typescript types from javascript, so users get the benefit of typescript and not port the project to ts.

Give me a few days while I finish the lats updates #38, I'll try to generate all the types, if I don't manage to create something that satisfy you, I'll give in and migrate to/learn typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript About the Javascript package
Projects
None yet
Development

No branches or pull requests

2 participants