Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expressions not working #24

Closed
MaartenMol opened this issue Nov 22, 2018 · 4 comments
Closed

Regular expressions not working #24

MaartenMol opened this issue Nov 22, 2018 · 4 comments

Comments

@MaartenMol
Copy link

MaartenMol commented Nov 22, 2018

When running a query in Grafana with expressions like name=~"test|123", no data is shown.

I don't know if this is normal or a bug?

@ghost
Copy link

ghost commented Jan 29, 2019

Hi @MaartenMol, can you please provide more insights for this request? I.e. what CrateDB version and setup, which Prometheus and grafana versions and setup you are using? What is the data you ingest from Prometheus and what is the schema in CrateDB you want to query?

@amotl
Copy link
Member

amotl commented Jan 17, 2023

Dear Maarten,

apologies for replying so late. The whole ecosystem has advanced since you've created this issue, so I am assuming this is not an issue anymore, and it will be safe to close this. Please let me know how to reproduce the error otherwise, and I will be happy to look into it.

With kind regards,
Andreas.

@amotl
Copy link
Member

amotl commented Jan 13, 2024

Dear Maarten,

hi again about this topic, and a happy new year. Even if you might no longer be interested (please tell us), we wanted to tell you that version 0.5.0 has been released today, and we are just now looking at your report again.

On this matter, we can only discover a225ebb and GH-27 making changes to the relevant code. By implementing prompb.LabelMatcher_RE and prompb.LabelMatcher_NRE, we think regular expressions should work in general.

Maybe it is specific to your expression, which includes the OR operator in form of the pipe symbol |?

With kind regards,
Andreas.

@amotl
Copy link
Member

amotl commented Jan 17, 2024

Hi again,

we added corresponding integration tests to verify a few variants of query expressions, and haven't been able to observe any problems so far.

Thus, I am closing this. Please feel free to re-open if you think the flaw is still there.

With kind regards,
Andreas.

/cc @WalBeh, @SStorm

@amotl amotl closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants