Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrateTestCluster is not terminated when a unit test fails #73

Open
mkleen opened this issue Dec 2, 2020 · 1 comment
Open

CrateTestCluster is not terminated when a unit test fails #73

mkleen opened this issue Dec 2, 2020 · 1 comment
Labels

Comments

@mkleen
Copy link

mkleen commented Dec 2, 2020

import io.crate.testing.CrateTestCluster;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Test;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.CoreMatchers.is;

public class ShutdownTest {

    private static CrateTestCluster testCluster;

    @BeforeClass
    public static void setUpClusterAndAgent() throws Throwable {
        testCluster = CrateTestCluster.fromURL("https://cdn.crate.io/downloads/releases/nightly/crate-latest.tar.gz")
                .keepWorkingDir(false)
                .build();
        testCluster.before();
    }

    @AfterClass
    public static void tearDown() {
        testCluster.after();
    }

    @Test
    public void test() {
        assertThat(true, is(false));
    }
}
@amotl
Copy link
Member

amotl commented Dec 18, 2024

Hi. We will probably want to run a new release after adding GH-87. In this spirit, let me ask if this one is still an issue?
If so, can it be fixed, or shall we focus on providing a first-class Testcontainers implementation instead?

The first link refers to the canonical documentation page about test layers for CrateDB, the second one is a reminder that crate-java-testing is missing on it.

My evaluation is that both variants can be used, while the Testcontainers thing is currently a future-looking thing, while even some of our own artefacts are actively using crate-java-testing. In this spirit, I think it should be fixed when possible.

@amotl amotl added the bug label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants