You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure if this is a known behavior or intended feature, but when beheading a villager, PlayerHeads uses the villager's profession name (if it has one) instead of just the generic name "Villager".
This only affects the behead message; the dropped item's name is "Villager Head" as expected.
The text was updated successfully, but these errors were encountered:
I think the code just uses the displayname of the mob, so I'm not sure there was really any intention here.
To be fair, I don't think it's "wrong" either way: Librarian was beheaded vs Villager was beheaded
both are accurate, but one is just more specific. I think the intention here is to inform of the event rather than describe the head itself.
If you think this needs changing,I have another hypothetical to consider:
you rename a special cat "Bob": Bob was beheaded
I assume with the current code (using displayname), Bob was beheaded is what is currently printed?
Perhaps, and maybe this is taking it too far, but an answer to both the original question and your hypothetical would be to use a behead message format with placeholders specified in the config, something like this: {ENTITY_NAME} was beheaded vs {ENTITY_TYPE} was beheaded
Which would resolve to Bob was beheaded vs Cat was beheaded, allowing people to choose which they prefer. This is fairly common practice among some popular plugins (example) so people will probably know how to use it.
I'll have to see if this possible, unfortunately PH was coded to use positional formatting ({0}{1}) so I'll have to verify it doesn't cause an exception if I supply replacements that don't exist (or add logic if it does).
Severity: very minor
Not sure if this is a known behavior or intended feature, but when beheading a villager, PlayerHeads uses the villager's profession name (if it has one) instead of just the generic name "Villager".
This only affects the behead message; the dropped item's name is "Villager Head" as expected.
The text was updated successfully, but these errors were encountered: