Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing RPM packages with DSA key #112

Open
bschelberg opened this issue Sep 27, 2016 · 0 comments
Open

Signing RPM packages with DSA key #112

bschelberg opened this issue Sep 27, 2016 · 0 comments

Comments

@bschelberg
Copy link

Signing an RPM package with a DSA key appears to be successful, but generates an RPM with an unverifiable signature.
CentOS 7 (RPM version 4.11.3):
error: skipping package <package> with unverifiable signature
CentOS 6 (RPM version 4.8.0):
error: skipping package <package> with unverifiable v4 signature

There doesn't seem to be any support in Redline for signing with a DSA key, but neither does the tool fail or even give a warning if the algorithm of the key is not supported.

From my cursory inspection of the code, it looks like the key is passed off to bouncycastle code to generate the signatures, but then added to the RPM in PGP and RSA headers (SignatureGenerator.prepare() method).

Are there any plans to support DSA keys? Or should a check be added to throw an exception if the key is DSA?

bschelberg pushed a commit to bschelberg/redline that referenced this issue Sep 28, 2016
…an unverifiable signature

IT seems like DSA has been deprecated by some projects, and we're strongly
encouraged to move to RSA. However, Redline RPM currently accepts DSA
keys for sigining, but signs the package incorrectly, resulting in
errors from RPM with errors that are difficult to diagnose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant