Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: craft generator - generated element action class contains errors #31

Closed
piotrpog opened this issue Nov 24, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@piotrpog
Copy link

What happened?

Description

New element action class generated by class generaor contains errors:

  • getTriggerHtml() method return value type is set to ?string, yet this method does not return anything. This makes Craft throw exception when we register this action class.
  • JS syntaxt error:
validateSelection: (selectedItems) {
  return true;
},

Craft CMS version

4.5.11.1

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@piotrpog piotrpog added the bug Something isn't working label Nov 24, 2023
@i-just i-just transferred this issue from craftcms/cms Nov 27, 2023
@i-just
Copy link

i-just commented Nov 28, 2023

Hi, thanks for reporting! Looks like someone already raised a PR for both of your points: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants