US-centric field names #2324
Replies: 4 comments
-
Thanks for the feedback. Will look to improve this. |
Beta Was this translation helpful? Give feedback.
-
Just realized that the labels for address fields should already be translated. https://github.com/craftcms/commerce/blob/develop/src/models/Address.php#L196-L217 You can you static translations (and pass in the |
Beta Was this translation helpful? Give feedback.
-
It's not really just the labels/translations. Naming the field It makes sense to make the labels generic, unless it's for a store that serves only one country. |
Beta Was this translation helpful? Give feedback.
-
Hi @missmatsuko This would be a large breaking change for something like this. We will need to look at this in a major version release. |
Beta Was this translation helpful? Give feedback.
-
Description
There's a couple naming choices in Commerce that are very specific to the US. I'm not sure if this is standard practice for eCommerce systems, but I find it a bit confusing, especially when we're serving countries other than the US.
e.g.
zipCode
makes me think that there could be ZIP validation on it.Steps to reproduce
Additional info
Beta Was this translation helpful? Give feedback.
All reactions