Fixed #15572 GQL not allowing overriding named transforms #15573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
brandonkelly
force-pushed
the
feature/pt-2102-5x-graphql-product-image-format-webp-not-working
branch
from
195471a to
fc8cd8e
Compare
brandonkelly
deleted the
feature/pt-2102-5x-graphql-product-image-format-webp-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Image transforms in GQL queries were not allowing argument overriding. As described in the docs
Updated the
Gql::parseTransformArguments()method to stop dumping of other arguments and prep them correctly for later being passed throughImageTransforms::normalizeTransform()Related issues
#15572