Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @property $path #14363

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Remove @property $path #14363

merged 1 commit into from
Feb 14, 2024

Conversation

bencroker
Copy link
Contributor

@bencroker bencroker commented Feb 12, 2024 •
edited
Loading

Removes @property $path, which does not seem to exist (possibly confused with the $pathInfo property that exists in the parent class).

This should be applied to the 5.0 branch too.

@bencroker bencroker changed the title Remove non-existent $path @property Remove @property $path Feb 12, 2024
@brandonkelly brandonkelly merged commit 5ff15f8 into craftcms:develop Feb 14, 2024
8 checks passed
@brandonkelly
Copy link
Member

Thanks! I think that’s a holdover from Craft 2 🤦🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bencroker @brandonkelly