Updates global sidebar to use rem instead of px #14351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brianjhanson was hoping for your input and a once-over on this one. I noticed that when browser/font zoom triggers the mobile sidebar layout, the |
|
@gcamacho079 fixed in f62e9cb. The rule governing the grid of |
Thank you so much, Brian! 👍🏼 |
…ollapsed-navigation-mode # Conflicts: # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map
[ci skip]
brandonkelly
deleted the
feature/acc-360-when-zooming-text-to-200-in-collapsed-navigation-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When users increase font size by 200%, the badge icon overlaps the navigation icon. This PR updates sizes and widths to use
remso that the notification icon doesn't overlap the icon at 200% zoom.In addition, it changes the breakpoints for the layout to use
reminstead ofpxwidths so that font size zoom triggers a shift to the mobile layout, increasing the screen real estate.Related issues