Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x]: badge count overflow issue #14406

Closed
lukeholder opened this issue Feb 16, 2024 · 1 comment
Closed

[5.x]: badge count overflow issue #14406

lukeholder opened this issue Feb 16, 2024 · 1 comment
Assignees
@brianjhanson
Labels
accessibility 👤 features related to accessibility bug ux 😄 features related to user experience

Comments

@lukeholder
Copy link
Member

lukeholder commented Feb 16, 2024 •
edited
Loading

What happened?

Description

Overflow issue with double digit numbers in source badge count.

CleanShot 2024-02-16 at 20 10 57@2x

Also, the data attributes for the badge count default to calling it a "notification". Maybe in the element Element::defineSources() we could pass a name for the badge count?

CleanShot 2024-02-16 at 20 14 03@2x

Craft CMS version

5.x

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions
@lukeholder lukeholder added bug accessibility 👤 features related to accessibility ux 😄 features related to user experience labels Feb 16, 2024
@brianjhanson brianjhanson self-assigned this Feb 16, 2024
brianjhanson added a commit that referenced this issue Feb 16, 2024
@brianjhanson
Fix badge overflow
72d596e 
Fixes #14406
This was referenced Feb 16, 2024
Merged
Merged
@brandonkelly
Copy link
Member

Both of those are resolved for the next release via #14409 and #14410.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianjhanson brianjhanson

Labels
accessibility 👤 features related to accessibility bug ux 😄 features related to user experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brandonkelly @lukeholder @brianjhanson