Skip to content

Commit

Permalink
Merge pull request #14377 from craftcms/feature/cms-1258-warning-heig…
Browse files Browse the repository at this point in the history
…ht-alignment-issue

Warning height alignment issue
  • Loading branch information
brandonkelly authored Feb 14, 2024
2 parents 2657ab4 + 4bbf1f7 commit e8faa36
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
1 change: 1 addition & 0 deletions src/templates/_layouts/components/alerts.twig
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
type: 'li',
style: {
'display': 'block',
'height': 'var(--header-height)'
},
} only %}
{% block content %}
Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/css/cp.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/css/cp.css.map

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions src/web/assets/cp/src/css/_cp.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ $badgeColor: var(--gray-800);
--neg-padding: calc(var(--padding) * -1);
--sidebar-width: #{$sidebarWidth};
--global-sidebar-width: #{$sidebarWidth};
--header-height: calc(44rem / 16);
}

html {
Expand Down Expand Up @@ -351,7 +352,7 @@ li.crumb .btn.menubtn,
border-bottom: 1px solid var(--hairline-color);

.flex {
height: calc(44rem / 16);
height: var(--header-height);
align-items: center;
}

Expand All @@ -372,7 +373,7 @@ li.crumb .btn.menubtn,
justify-content: center;
width: 44px;
min-width: 44px;
height: calc(44rem / 16);
height: var(--header-height);
border-right: 1px solid var(--medium-hairline-color);
line-height: 26px;
color: currentColor;
Expand Down Expand Up @@ -420,7 +421,7 @@ li.crumb .btn.menubtn,
align-items: stretch;
flex-wrap: nowrap;
max-width: 100%;
height: calc(44rem / 16);
height: var(--header-height);

--arrow-padding: 10;
--arrow-height: 22;
Expand Down

0 comments on commit e8faa36

Please sign in to comment.