Skip to content

Commit

Permalink
Merge branch 'develop' of https://github.com/craftcms/cms into 5.0
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonkelly committed Feb 13, 2024
2 parents 28b2575 + e3bfd9b commit 568796d
Show file tree
Hide file tree
Showing 6 changed files with 47 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/BUG-REPORT-V3.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Bug ReportCraft 3
name: "Bug Report: Craft 3"
description: Report an issue or unexpected behavior pertaining to Craft 3
title: '[3.x]: '
labels:
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/BUG-REPORT-V4.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Bug ReportCraft 4
name: "Bug Report: Craft 4"
description: Report an issue or unexpected behavior pertaining to Craft 4
title: '[4.x]: '
labels:
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/BUG-REPORT-V5.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Bug ReportCraft 5
name: "Bug Report: Craft 5"
description: Report an issue or unexpected behavior pertaining to Craft 5
title: '[5.x]: '
labels:
Expand Down
33 changes: 27 additions & 6 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,41 @@
blank_issues_enabled: false
contact_links:
- name: Feature Request
url: https://github.com/craftcms/cms/discussions/new?category=ideas
about: Start a new discussion about your idea
- name: Documentation
url: https://docs.craftcms.com/
url: https://craftcms.com/docs
about: Read the official documentation
- name: Knowledge Base
url: https://craftcms.com/knowledge-base
about: Find answers to common problems
about: Find official answers to common problems
- name: Developer Support Services
url: https://craftcms.com/support-services
about: Priority developer support from the team that makes Craft
- name: Craft Discord
url: https://craftcms.com/discord
about: Meet the community
- name: Stack Exchange
- name: Craft Stack Exchange
url: https://craftcms.stackexchange.com/
about: Get help and help others
- name: "Feature Request: Craft CMS"
url: https://github.com/craftcms/cms/discussions/new?category=ideas
about: Make a feature request or enhancement for Craft CMS
- name: "Feature Request: Craft Console / Plugin Store"
url: https://github.com/craftcms/console/discussions/new?category=ideas
about: Make a feature request or enhancement for Craft Console or the Plugin Store
- name: "Feature Request: Craft Cloud"
url: https://github.com/craftcms/cloud/discussions/new?category=ideas
about: Make a feature request or enhancement for Craft Cloud
- name: "Feature Request: Craft Commerce"
url: https://github.com/craftcms/commerce/discussions/new?category=ideas
about: Make a feature request or enhancement for Craft Commerce
- name: "Bug Report: Craft CMS"
url: https://github.com/craftcms/cms/issues/new/choose
about: Create a bug report for Craft CMS
- name: "Bug Report: Craft Console / Plugin Store"
url: https://github.com/craftcms/console/issues/new/choose
about: Create a bug report for Craft Console or the Plugin Store
- name: "Bug Report: Craft Cloud"
url: https://craftcms.com/contact
about: Create a bug report for Craft Cloud
- name: "Bug Report: Craft Commerce"
url: https://github.com/craftcms/commerce/issues/new/choose
about: Create a bug report for Craft Commerce
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
- Fixed a bug where GraphQL schema edit pages could include empty category headings.
- Fixed a bug where asset slideouts weren’t showing validation errors on the Filename field. ([#14329](https://github.com/craftcms/cms/issues/14329))
- Fixed a bug where element slideouts would open when long-pressing on an element’s “Remove” button within an element select input.
- Fixed a bug where relations weren’t getting deleted when an element was deleted for a site. ([#14347](https://github.com/craftcms/cms/issues/14347))

## 5.0.0-beta.1 - 2024-02-08

Expand Down
16 changes: 16 additions & 0 deletions src/fields/BaseRelationField.php
Original file line number Diff line number Diff line change
Expand Up @@ -1056,6 +1056,22 @@ public function afterElementSave(ElementInterface $element, bool $isNew): void
parent::afterElementSave($element, $isNew);
}

/**
* @inheritdoc
*/
public function afterElementDeleteForSite(ElementInterface $element): void
{
if ($this->localizeRelations) {
Db::delete(DbTable::RELATIONS, [
'fieldId' => $this->id,
'sourceSiteId' => $element->siteId,
'sourceId' => $element->id,
]);
}

parent::afterElementDeleteForSite($element);
}

/**
* Normalizes the available sources into select input options.
*
Expand Down

0 comments on commit 568796d

Please sign in to comment.