Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent using URL of the same site #11

Open
cr0ybot opened this issue Mar 29, 2023 · 0 comments
Open

Prevent using URL of the same site #11

cr0ybot opened this issue Mar 29, 2023 · 0 comments
Assignees

Comments

@cr0ybot
Copy link
Owner

cr0ybot commented Mar 29, 2023

The core RSS block prevents pulling in a feed with the same URL as the current site. I think this is probably wise, but I'd like to offer a filter to allow it for some advanced usage that I might not fully grasp at this point.

This should probably be handled by the FeedBlock\Feed\get_feed function so that it can be filtered once in PHP. Will have to consider what kind of return value (WP_Error?) would make the most sense and how that is handled both in editor and front end.

@cr0ybot cr0ybot self-assigned this Mar 29, 2023
@cr0ybot cr0ybot added this to the WP Plugin Repo Release milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant