Fix list key warning

Signed-off-by: Carlos Quiroz <[email protected]>
cquiroz · Jan 11, 2020 · 0d47d58 · 0d47d58
1 parent adfe2fe
commit 0d47d58
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 14 deletions.
diff --git a/facade/src/main/scala/react/semanticui/elements/list/List.scala b/facade/src/main/scala/react/semanticui/elements/list/List.scala
@@ -163,9 +163,6 @@ object List {
   private val component =
     JsComponent[ListProps, Children.Varargs, Null](RawComponent)
 
-  def apply(
-    items: SList[ListItem]
-  ): List =
-    new List(items = items)
+  def apply(items: SList[ListItem]): List = new List(items = items)
 
 }
diff --git a/facade/src/main/scala/react/semanticui/elements/list/ListItem.scala b/facade/src/main/scala/react/semanticui/elements/list/ListItem.scala
@@ -24,7 +24,6 @@ final case class ListItem(
   header:                js.UndefOr[VdomNode | ListHeader]      = js.undefined,
   icon:                  js.UndefOr[VdomNode | ListIcon]        = js.undefined,
   image:                 js.UndefOr[VdomNode | Image]           = js.undefined,
-  key:                   js.UndefOr[Key]                        = js.undefined,
   onClickE:              js.UndefOr[ListItem.OnClick]           = js.undefined,
   onClick:               js.UndefOr[Callback]                   = js.undefined,
   value:                 js.UndefOr[String]                     = js.undefined,
@@ -85,8 +84,6 @@ object ListItem {
     /** Shorthand for Image. */
     var image: js.UndefOr[suiraw.SemanticShorthandItem[Image.ImageProps]] = js.native
 
-    var key: js.UndefOr[Key] = js.native
-
     /**
       * Called on click.
       *
@@ -111,7 +108,6 @@ object ListItem {
              q.header,
              q.icon,
              q.image,
-             q.key,
              q.onClickE,
              q.onClick,
              q.value)
@@ -128,7 +124,6 @@ object ListItem {
     header:      js.UndefOr[VdomNode | ListHeader]      = js.undefined,
     icon:        js.UndefOr[VdomNode | ListIcon]        = js.undefined,
     image:       js.UndefOr[VdomNode | Image]           = js.undefined,
-    key:         js.UndefOr[Key]                        = js.undefined,
     onClickE:    js.UndefOr[ListItem.OnClick]           = js.undefined,
     onClick:     js.UndefOr[Callback]                   = js.undefined,
     value:       js.UndefOr[String]                     = js.undefined
@@ -144,7 +139,6 @@ object ListItem {
     p.header      = fnToRawOrProps(header)
     p.icon        = toRawOrPropsP(icon)
     p.image       = fnToRawOrProps(image)
-    p.key         = key
     p.onClick     = (onClickE, onClick).toJs
     p.value       = value
     p

diff --git a/facade/src/test/scala/react/semanticui/elements/list/ListTests.scala b/facade/src/test/scala/react/semanticui/elements/list/ListTests.scala
@@ -7,13 +7,13 @@ import japgolly.scalajs.react.vdom.html_<^._
 object ListTests extends TestSuite {
   val tests = Tests {
     test("render") {
-      val item1 = ListItem("a")
-      val item2 = ListItem("b")
-      val list  = List(item1 :: item2 :: Nil)
+      val item1 = ListItem(value = "a")("a")
+      val item2 = ListItem(value = "b")("b")
+      val list  = List()(item1, item2)
       ReactTestUtils.withNewBodyElement { mountNode =>
         list.renderIntoDOM(mountNode)
         assert(
-          mountNode.innerHTML == """<div role="list" class="ui list"><div role="listitem" class="item">a</div><div role="listitem" class="item">b</div></div>"""
+          mountNode.innerHTML == """<div role="list" class="ui list"><div data-value="a" role="listitem" class="item">a</div><div data-value="b" role="listitem" class="item">b</div></div>"""
         )
       }
     }