Skip to content
This repository was archived by the owner on Feb 10, 2023. It is now read-only.

Commit 0d47d58

Browse files
committed
Fix list key warning
Signed-off-by: Carlos Quiroz <[email protected]>
1 parent adfe2fe commit 0d47d58

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

facade/src/main/scala/react/semanticui/elements/list/List.scala

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,6 @@ object List {
163163
private val component =
164164
JsComponent[ListProps, Children.Varargs, Null](RawComponent)
165165

166-
def apply(
167-
items: SList[ListItem]
168-
): List =
169-
new List(items = items)
166+
def apply(items: SList[ListItem]): List = new List(items = items)
170167

171168
}

facade/src/main/scala/react/semanticui/elements/list/ListItem.scala

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ final case class ListItem(
2424
header: js.UndefOr[VdomNode | ListHeader] = js.undefined,
2525
icon: js.UndefOr[VdomNode | ListIcon] = js.undefined,
2626
image: js.UndefOr[VdomNode | Image] = js.undefined,
27-
key: js.UndefOr[Key] = js.undefined,
2827
onClickE: js.UndefOr[ListItem.OnClick] = js.undefined,
2928
onClick: js.UndefOr[Callback] = js.undefined,
3029
value: js.UndefOr[String] = js.undefined,
@@ -85,8 +84,6 @@ object ListItem {
8584
/** Shorthand for Image. */
8685
var image: js.UndefOr[suiraw.SemanticShorthandItem[Image.ImageProps]] = js.native
8786

88-
var key: js.UndefOr[Key] = js.native
89-
9087
/**
9188
* Called on click.
9289
*
@@ -111,7 +108,6 @@ object ListItem {
111108
q.header,
112109
q.icon,
113110
q.image,
114-
q.key,
115111
q.onClickE,
116112
q.onClick,
117113
q.value)
@@ -128,7 +124,6 @@ object ListItem {
128124
header: js.UndefOr[VdomNode | ListHeader] = js.undefined,
129125
icon: js.UndefOr[VdomNode | ListIcon] = js.undefined,
130126
image: js.UndefOr[VdomNode | Image] = js.undefined,
131-
key: js.UndefOr[Key] = js.undefined,
132127
onClickE: js.UndefOr[ListItem.OnClick] = js.undefined,
133128
onClick: js.UndefOr[Callback] = js.undefined,
134129
value: js.UndefOr[String] = js.undefined
@@ -144,7 +139,6 @@ object ListItem {
144139
p.header = fnToRawOrProps(header)
145140
p.icon = toRawOrPropsP(icon)
146141
p.image = fnToRawOrProps(image)
147-
p.key = key
148142
p.onClick = (onClickE, onClick).toJs
149143
p.value = value
150144
p

facade/src/test/scala/react/semanticui/elements/list/ListTests.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ import japgolly.scalajs.react.vdom.html_<^._
77
object ListTests extends TestSuite {
88
val tests = Tests {
99
test("render") {
10-
val item1 = ListItem("a")
11-
val item2 = ListItem("b")
12-
val list = List(item1 :: item2 :: Nil)
10+
val item1 = ListItem(value = "a")("a")
11+
val item2 = ListItem(value = "b")("b")
12+
val list = List()(item1, item2)
1313
ReactTestUtils.withNewBodyElement { mountNode =>
1414
list.renderIntoDOM(mountNode)
1515
assert(
16-
mountNode.innerHTML == """<div role="list" class="ui list"><div role="listitem" class="item">a</div><div role="listitem" class="item">b</div></div>"""
16+
mountNode.innerHTML == """<div role="list" class="ui list"><div data-value="a" role="listitem" class="item">a</div><div data-value="b" role="listitem" class="item">b</div></div>"""
1717
)
1818
}
1919
}

0 commit comments

Comments
 (0)