Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of the LibraryManager.enableCaching feature #14

Open
brynrhodes opened this issue Sep 11, 2021 · 1 comment
Open

Take advantage of the LibraryManager.enableCaching feature #14

brynrhodes opened this issue Sep 11, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@brynrhodes
Copy link
Member

The Language Server currently implements a NonCachingLibraryManager to avoid caching libraries in the LibraryManager. To avoid the need to subclass, an option is being added to the base LibraryManager (cqframework/clinical_quality_language#667). Once this issue is complete, remove the NonCachingLibraryManager class from the language server and just set the option instead.

@brynrhodes brynrhodes added the enhancement New feature or request label Sep 11, 2021
@JPercival
Copy link
Contributor

I actually think we do want to cache in the interest of maximal language server performance. The noncaching behavior is a hackaround for not being able to expire the library cache on a per library basis. So, I'd argue that the caching option is not the optimal solution for this. Rather, we need an API that allows us to control the Library cache on a more granular basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants