Skip to content

Commit 4deb075

Browse files
committed
batch polishing
1 parent 9de78ad commit 4deb075

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

Diff for: bestcust/src/main/java/io/spring/s1bestcust/config/BestCustomerConfiguration.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public FlatFileItemReader<BillEntry> reader(BestCustomerProperties properties)
9191

9292
DelimitedLineTokenizer tokenizer = new DelimitedLineTokenizer();
9393
tokenizer.setDelimiter(",");
94-
tokenizer.setNames(new String[]{ "id", "firstName", "lastName", "planId", "planName", "callPrice", "dataPrice", "usageInMinutes", "usageInBytes", "dataBillAmount", "callBillAmount", "totalBillAmount" });
94+
tokenizer.setNames(new String[]{ "id", "firstName", "lastName", "planId", "totalBillAmount" });
9595

9696
DefaultLineMapper lineMapper = new DefaultLineMapper<BillEntry>();
9797
lineMapper.setLineTokenizer(tokenizer);

Diff for: billrun/src/main/java/io/spring/billrun/config/BillrunConfiguration.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public BillrunProperties properties() {
6060
}
6161

6262
@Bean
63-
public Job billRunJob(BillrunProperties properties, Step step) {
63+
public Job billRunJob(Step step) {
6464
return jobBuilderFactory
6565
.get("billRunJob")
6666
.incrementer(new RunIdIncrementer())
@@ -70,7 +70,7 @@ public Job billRunJob(BillrunProperties properties, Step step) {
7070
}
7171

7272
@Bean
73-
public Step step(BillrunProperties properties, ItemReader itemReader,
73+
public Step step(ItemReader itemReader,
7474
ItemProcessor itemProcessor,
7575
ItemWriter itemWriter) {
7676
return stepBuilderFactory.get("step1").<BillEntry, BillEntry>chunk(5)
@@ -81,7 +81,7 @@ public Step step(BillrunProperties properties, ItemReader itemReader,
8181
}
8282

8383
@Bean
84-
public ItemReader<BillEntry> reader(BillrunProperties properties) {
84+
public ItemReader<BillEntry> reader() {
8585
return new JdbcCursorItemReaderBuilder<BillEntry>()
8686
.dataSource(this.dataSource)
8787
.name("creditReader")
@@ -111,7 +111,7 @@ public ItemWriter<BillEntry> writer(BillrunProperties properties) {
111111
.encoding("UTF-16")
112112
.saveState(false)
113113
.shouldDeleteIfEmpty(true)
114-
.append(true)
114+
.append(false)
115115
.forceSync(true)
116116
.shouldDeleteIfEmpty(true)
117117
.transactional(false)

Diff for: billrun/src/main/java/io/spring/billrun/entity/BillEntry.java

+11
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,27 @@
1818

1919
public class BillEntry {
2020
private int userId;
21+
2122
private String firstName;
23+
2224
private String lastName;
25+
2326
private int planId;
27+
2428
private String planName;
29+
2530
private double callPrice;
31+
2632
private double dataPrice;
33+
2734
private int usageInMinutes;
35+
2836
private int usageInBytes;
37+
2938
private double dataBillAmount;
39+
3040
private double callBillAmount;
41+
3142
private double totalBillAmount;
3243

3344
public int getUserId() {

0 commit comments

Comments
 (0)